From: Vinod Koul <vinod.koul@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon <horms@verge.net.au>, Linux-SH <linux-sh@vger.kernel.org>,
Cao Minh Hiep <cm-hiep@jinso.co.jp>,
Magnus <magnus.damm@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Laurent <laurent.pinchart@ideasonboard.com>,
dmaengine@vger.kernel.org, sakato <ryusuke.sakato.bx@renesas.com>,
Nguyen Viet Dung <nv-dung@jinso.co.jp>
Subject: Re: [PATCH 1/4 v2] dmaengine: rcar-dmac: fixup spinlock in rcar-dmac
Date: Fri, 22 May 2015 17:58:05 +0530 [thread overview]
Message-ID: <20150522122805.GW3140@localhost> (raw)
In-Reply-To: <877fs2twwm.wl%kuninori.morimoto.gx@renesas.com>
On Thu, May 21, 2015 at 03:48:38AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current rcar-dmac driver is using spin_lock_irq() / spin_unlock_irq()
> in some functions. But, some other driver might call DMAEngine API
> during interrupt disabled. In such case, rcar-dmac side spin_unlock_irq()
> forcefully allows all interrupts. Therefore, other driver receives
> unexpected interruption, and its exclusive access control will be broken.
> This patch replaces spin_lock_irq() to spin_lock_irqsave(),
> and spin_unlock_irq() to spin_unlock_irqrestore().
>
> Reported-by: Cao Minh Hiep <cm-hiep@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Tested-by: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Mark, please apply this thru your tree
Thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon <horms@verge.net.au>, Linux-SH <linux-sh@vger.kernel.org>,
Cao Minh Hiep <cm-hiep@jinso.co.jp>,
Magnus <magnus.damm@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Laurent <laurent.pinchart@ideasonboard.com>,
dmaengine@vger.kernel.org, sakato <ryusuke.sakato.bx@renesas.com>,
Nguyen Viet Dung <nv-dung@jinso.co.jp>
Subject: Re: [PATCH 1/4 v2] dmaengine: rcar-dmac: fixup spinlock in rcar-dmac
Date: Fri, 22 May 2015 12:40:05 +0000 [thread overview]
Message-ID: <20150522122805.GW3140@localhost> (raw)
In-Reply-To: <877fs2twwm.wl%kuninori.morimoto.gx@renesas.com>
On Thu, May 21, 2015 at 03:48:38AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current rcar-dmac driver is using spin_lock_irq() / spin_unlock_irq()
> in some functions. But, some other driver might call DMAEngine API
> during interrupt disabled. In such case, rcar-dmac side spin_unlock_irq()
> forcefully allows all interrupts. Therefore, other driver receives
> unexpected interruption, and its exclusive access control will be broken.
> This patch replaces spin_lock_irq() to spin_lock_irqsave(),
> and spin_unlock_irq() to spin_unlock_irqrestore().
>
> Reported-by: Cao Minh Hiep <cm-hiep@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Tested-by: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Mark, please apply this thru your tree
Thanks
--
~Vinod
next prev parent reply other threads:[~2015-05-22 12:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 3:47 [PATCH 0/4 v2] ASoC: rsnd: fixup interrupt / spin lock issue Kuninori Morimoto
2015-05-21 3:48 ` [PATCH 1/4 v2] dmaengine: rcar-dmac: fixup spinlock in rcar-dmac Kuninori Morimoto
2015-05-22 12:28 ` Vinod Koul [this message]
2015-05-22 12:40 ` Vinod Koul
2015-05-22 13:14 ` Mark Brown
2015-05-22 13:14 ` Mark Brown
2015-05-21 3:49 ` [PATCH 2/4 v2] ASoC: rsnd: indicate unknown HW start Kuninori Morimoto
2015-05-21 3:49 ` Kuninori Morimoto
2015-05-21 10:46 ` Mark Brown
2015-05-21 10:46 ` Mark Brown
2015-05-21 3:49 ` [PATCH 3/4 v2] ASoC: rsnd: add rsnd_dai_stream_quit() Kuninori Morimoto
2015-05-21 10:59 ` Mark Brown
2015-05-21 10:59 ` Mark Brown
2015-05-21 3:50 ` [PATCH 4/4 v2] ASoC: rsnd: spin lock for interrupt handler Kuninori Morimoto
2015-05-21 3:50 ` Kuninori Morimoto
2015-05-21 10:59 ` Mark Brown
2015-05-21 10:59 ` Mark Brown
2015-05-21 16:15 ` Vinod Koul
2015-05-21 16:27 ` Vinod Koul
2015-05-21 16:46 ` Mark Brown
2015-05-21 16:46 ` Mark Brown
2015-05-21 23:59 ` Kuninori Morimoto
2015-05-22 13:15 ` Mark Brown
2015-05-22 13:15 ` Mark Brown
2015-05-21 6:32 ` [PATCH 0/4 v2] ASoC: rsnd: fixup interrupt / spin lock issue Cao Minh Hiep
2015-05-21 6:32 ` Cao Minh Hiep
2015-05-22 1:41 ` Cao Minh Hiep
2015-05-22 1:41 ` Cao Minh Hiep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522122805.GW3140@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cm-hiep@jinso.co.jp \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=nv-dung@jinso.co.jp \
--cc=ryusuke.sakato.bx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.