All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Russell King <linux@arm.linux.org.uk>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	fabio.estevam@freescale.com, sebastien.szymanski@armadeus.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem
Date: Sat, 23 May 2015 19:41:49 +0200	[thread overview]
Message-ID: <20150523174149.GA16004@earth> (raw)
In-Reply-To: <1430346747-28728-4-git-send-email-stefan.wahren@i2se.com>

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi,

On Wed, Apr 29, 2015 at 10:32:24PM +0000, Stefan Wahren wrote:
> This patch adds a minimal driver for the Freescale i.MX23, i.MX28
> power subsystem. It's required to trigger the probing of the underlying
> drivers like on-chip regulators.

I'm not sure what you need the power supply class for. I see only
one property (ac connected), which is constant. Maybe just drop
the power supply stuff?

This would leave an almost empty driver, which just sets a single
register at probe time and probes more drivers. That would probably
be more fitting for the MFD subsystem.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem
Date: Sat, 23 May 2015 19:41:49 +0200	[thread overview]
Message-ID: <20150523174149.GA16004@earth> (raw)
In-Reply-To: <1430346747-28728-4-git-send-email-stefan.wahren@i2se.com>

Hi,

On Wed, Apr 29, 2015 at 10:32:24PM +0000, Stefan Wahren wrote:
> This patch adds a minimal driver for the Freescale i.MX23, i.MX28
> power subsystem. It's required to trigger the probing of the underlying
> drivers like on-chip regulators.

I'm not sure what you need the power supply class for. I see only
one property (ac connected), which is constant. Maybe just drop
the power supply stuff?

This would leave an almost empty driver, which just sets a single
register at probe time and probes more drivers. That would probably
be more fitting for the MFD subsystem.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150523/d2e569a5/attachment.sig>

  reply	other threads:[~2015-05-23 17:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 22:32 [PATCH V2 0/6] regulator: enable regulator support for i.MX23/i.MX28 Stefan Wahren
2015-04-29 22:32 ` Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 1/6] DT: add binding for mxs power subsystem Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 2/6] ARM: mxs: select syscon for platform Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2015-05-23 17:41   ` Sebastian Reichel [this message]
2015-05-23 17:41     ` Sebastian Reichel
2015-05-27  7:12     ` Stefan Wahren
2015-05-27  7:12       ` Stefan Wahren
2015-05-27 13:51       ` Sebastian Reichel
2015-05-27 13:51         ` Sebastian Reichel
2015-05-27 16:34         ` Stefan Wahren
2015-05-27 16:34           ` Stefan Wahren
2015-05-28 17:38           ` Sebastian Reichel
2015-05-28 17:38             ` Sebastian Reichel
2015-04-29 22:32 ` [PATCH V2 4/6] DT: add binding for mxs on-chip regulators Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2015-05-04 13:51   ` Jürgen Borleis
2015-05-04 13:51     ` Jürgen Borleis
2015-05-04 20:20     ` Stefan Wahren
2015-05-04 20:20       ` Stefan Wahren
2015-05-05  8:21       ` Jürgen Borleis
2015-05-05  8:21         ` Jürgen Borleis
     [not found]         ` <201505051021.01939.jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-05 17:12           ` Stefan Wahren
2015-05-05 17:12             ` Stefan Wahren
2015-04-29 22:32 ` [PATCH V2 5/6] regulator: add mxs on-chip regulator driver Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2015-05-04 12:36   ` Mark Brown
2015-05-04 12:36     ` Mark Brown
     [not found]     ` <20150504123648.GU15510-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-04 20:34       ` Stefan Wahren
2015-05-04 20:34         ` Stefan Wahren
2015-05-07 18:37         ` Stefan Wahren
2015-05-07 18:37           ` Stefan Wahren
2015-05-07 18:52           ` Mark Brown
2015-05-07 18:52             ` Mark Brown
     [not found]             ` <20150507185216.GP22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-07 19:25               ` Stefan Wahren
2015-05-07 19:25                 ` Stefan Wahren
2015-05-07 19:32                 ` Mark Brown
2015-05-07 19:32                   ` Mark Brown
2015-05-26 12:16                   ` Stefan Wahren
2015-05-26 12:16                     ` Stefan Wahren
2015-05-27 17:33                     ` Mark Brown
2015-05-27 17:33                       ` Mark Brown
     [not found]                       ` <20150527173321.GH21577-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-27 20:58                         ` Stefan Wahren
2015-05-27 20:58                           ` Stefan Wahren
2015-05-28 14:26                           ` Mark Brown
2015-05-28 14:26                             ` Mark Brown
2015-04-29 22:32 ` [PATCH V2 6/6] ARM: dts: enable regulator support for i.MX23/i.MX28 Stefan Wahren
2015-04-29 22:32   ` Stefan Wahren
2016-03-21 16:21 ` [PATCH V2 0/6] regulator: " Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150523174149.GA16004@earth \
    --to=sre@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=fabio.estevam@freescale.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastien.szymanski@armadeus.com \
    --cc=shawn.guo@linaro.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.