From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: berlin: add SPI nodes for BG2Q
Date: Mon, 25 May 2015 11:01:00 +0200 [thread overview]
Message-ID: <20150525090100.GC29660@kwain> (raw)
In-Reply-To: <555D1706.7040309@gmail.com>
On Thu, May 21, 2015 at 01:21:42AM +0200, Sebastian Hesselbarth wrote:
> On 20.05.2015 14:53, Antoine Tenart wrote:
> >+
> >+ spi0_pmux: spi0-pmux {
> >+ groups = "G8", "G9", "G10", "G11";
> >+ function = "spi1";
> >+ };
>
> ... can you check which of G8-G11 are actually clock/data and which
> are CSn lines?
>
> CSn lines should all be optional and per-board pinmux - same for the
> other spi pinmux.
G8 and GSM3 are for clock/data, the other groups (G9-11 and GSM0-2)
control the CSn lines. I'll update.
> > };
> >
> > chip_rst: reset {
> >@@ -473,6 +492,20 @@
> > };
> > };
> >
> >+ spi1: spi at 5000 {
> >+ compatible = "snps,dw-apb-ssi";
> >+ reg = <0x6000 0x100>;
>
> s/spi at 5000/spi at 6000/
Oops.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
zmxu@marvell.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: berlin: add SPI nodes for BG2Q
Date: Mon, 25 May 2015 11:01:00 +0200 [thread overview]
Message-ID: <20150525090100.GC29660@kwain> (raw)
In-Reply-To: <555D1706.7040309@gmail.com>
On Thu, May 21, 2015 at 01:21:42AM +0200, Sebastian Hesselbarth wrote:
> On 20.05.2015 14:53, Antoine Tenart wrote:
> >+
> >+ spi0_pmux: spi0-pmux {
> >+ groups = "G8", "G9", "G10", "G11";
> >+ function = "spi1";
> >+ };
>
> ... can you check which of G8-G11 are actually clock/data and which
> are CSn lines?
>
> CSn lines should all be optional and per-board pinmux - same for the
> other spi pinmux.
G8 and GSM3 are for clock/data, the other groups (G9-11 and GSM0-2)
control the CSn lines. I'll update.
> > };
> >
> > chip_rst: reset {
> >@@ -473,6 +492,20 @@
> > };
> > };
> >
> >+ spi1: spi@5000 {
> >+ compatible = "snps,dw-apb-ssi";
> >+ reg = <0x6000 0x100>;
>
> s/spi@5000/spi@6000/
Oops.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-25 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 12:53 [PATCH] ARM: berlin: add SPI nodes for BG2Q Antoine Tenart
2015-05-20 12:53 ` Antoine Tenart
2015-05-20 16:58 ` Sebastian Hesselbarth
2015-05-20 16:58 ` Sebastian Hesselbarth
2015-05-25 8:59 ` Antoine Tenart
2015-05-25 8:59 ` Antoine Tenart
2015-05-20 23:21 ` Sebastian Hesselbarth
2015-05-20 23:21 ` Sebastian Hesselbarth
2015-05-25 9:01 ` Antoine Tenart [this message]
2015-05-25 9:01 ` Antoine Tenart
2015-05-27 8:36 ` Sebastian Hesselbarth
2015-05-27 8:36 ` Sebastian Hesselbarth
2015-05-27 13:42 ` Antoine Tenart
2015-05-27 13:42 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525090100.GC29660@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.