From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT
Date: Mon, 25 May 2015 09:48:42 +0000 [thread overview]
Message-ID: <20150525094842.GB22558@mwanda> (raw)
In-Reply-To: <20150523173245.GA31663@mwanda>
On Mon, May 25, 2015 at 10:30:38AM +0530, Sudip Mukherjee wrote:
> On Sat, May 23, 2015 at 08:32:45PM +0300, Dan Carpenter wrote:
> > Hello Thomas Niederprüm,
>
> > But I also have a hard time remembering if | or << is higher precedence
>
> man page of operator (man operator) will show the precedence.
> << is higher precendence than |
The point is that people should just use parenthesis when it's not
something that's obvious.
Also the more I think about it, writing "!par->com_seq & 0x1" is
nonsense. If that's really what was intended then just say
"!par->com_seq". I think it's a bug though and "!(par->com_seq & 0x1)"
is intended.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-25 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 17:32 fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Dan Carpenter
2015-05-25 5:12 ` Sudip Mukherjee
2015-05-25 7:34 ` Thomas Niederprüm
2015-05-25 9:48 ` Dan Carpenter [this message]
2015-05-25 10:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525094842.GB22558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.