From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT
Date: Mon, 25 May 2015 21:08:12 +0800 [thread overview]
Message-ID: <20150525130810.GA18550@shlinux2> (raw)
In-Reply-To: <20150521011629.GA25156@shlinux2>
Hi Stefano,
On Thu, May 21, 2015 at 09:16:32AM +0800, Peng Fan wrote:
>Hi Marek,
>
>On Wed, May 20, 2015 at 01:06:21PM +0200, Marek Vasut wrote:
>>On Wednesday, May 20, 2015 at 04:28:48 AM, Peng Fan wrote:
>>> We should not hardcode MXS_DMA_ALIGNMENT to 32, since we can not guarantee
>>> that socs' cache line size is 32 bytes.
>>> If on chips whose cache line size is 64 bytes, error occurs:
>>
>>Which chips are those?
>i.MX7's L1 Cache line size is 64 bytes.
>>
>>> NAND: ERROR: v7_dcache_inval_range - start address is not aligned -
>>> 0xbdf1d1a0 ERROR: v7_dcache_inval_range - stop address is not aligned -
>>> 0xbdf1f4a0 ERROR: v7_dcache_inval_range - start address is not aligned -
>>> 0xbdf1d1a0 "
>>> Align MXS_DMA_ALIGNMENT with ARCH_DMA_MINALIGN whose value is same to
>>> CONFIG_SYS_CACHELINE_SIZE if CONFIG_SYS_CACHELINE_SIZE defined.
>>>
>>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>>
>>Acked-by: Marek Vasut <marex@denx.de>
Will you apply this patch?
>>
>>Best regards,
>>Marek Vasut
>
>Regards,
>Peng.
>--
Regards,
Peng
--
next prev parent reply other threads:[~2015-05-25 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 2:28 [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT Peng Fan
2015-05-20 11:06 ` Marek Vasut
2015-05-21 1:16 ` Peng Fan
2015-05-21 1:26 ` Marek Vasut
2015-05-25 13:08 ` Peng Fan [this message]
2015-05-26 12:16 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525130810.GA18550@shlinux2 \
--to=b51431@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.