From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT
Date: Tue, 26 May 2015 14:16:20 +0200 [thread overview]
Message-ID: <55646414.2000706@denx.de> (raw)
In-Reply-To: <1432088928-7414-1-git-send-email-Peng.Fan@freescale.com>
On 20/05/2015 04:28, Peng Fan wrote:
> We should not hardcode MXS_DMA_ALIGNMENT to 32, since we can not guarantee
> that socs' cache line size is 32 bytes.
> If on chips whose cache line size is 64 bytes, error occurs:
> "
> NAND: ERROR: v7_dcache_inval_range - start address is not aligned - 0xbdf1d1a0
> ERROR: v7_dcache_inval_range - stop address is not aligned - 0xbdf1f4a0
> ERROR: v7_dcache_inval_range - start address is not aligned - 0xbdf1d1a0
> "
> Align MXS_DMA_ALIGNMENT with ARCH_DMA_MINALIGN whose value is same to
> CONFIG_SYS_CACHELINE_SIZE if CONFIG_SYS_CACHELINE_SIZE defined.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> ---
> arch/arm/include/asm/imx-common/dma.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/imx-common/dma.h b/arch/arm/include/asm/imx-common/dma.h
> index d5c1f7f..7d421b3 100644
> --- a/arch/arm/include/asm/imx-common/dma.h
> +++ b/arch/arm/include/asm/imx-common/dma.h
> @@ -22,7 +22,7 @@
> #define DMA_PIO_WORDS CONFIG_ARCH_DMA_PIO_WORDS
> #endif
>
> -#define MXS_DMA_ALIGNMENT 32
> +#define MXS_DMA_ALIGNMENT ARCH_DMA_MINALIGN
>
> /*
> * MXS DMA channels
>
Applied to u-boot-imx, thanks!
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2015-05-26 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 2:28 [U-Boot] [PATCH] imx: dma: correct MXS_DMA_ALIGNMENT Peng Fan
2015-05-20 11:06 ` Marek Vasut
2015-05-21 1:16 ` Peng Fan
2015-05-21 1:26 ` Marek Vasut
2015-05-25 13:08 ` Peng Fan
2015-05-26 12:16 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55646414.2000706@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.