From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: mvebu: add support for the new Aramda 385 based Linksys boards
Date: Mon, 25 May 2015 16:08:40 +0200 [thread overview]
Message-ID: <20150525140840.GA8883@lunn.ch> (raw)
In-Reply-To: <55631C6E.8050700@free-electrons.com>
On Mon, May 25, 2015 at 02:58:22PM +0200, Gregory CLEMENT wrote:
> Hi Imre,
>
> On 20/05/2015 23:14, Imre Kaloz wrote:
> > This patch adds support for the Linksys WRT1200AC (Caiman) and
> > the Linksys WRT1900AC v2 (Cobra).
> >
> > Both boards have:
> >
> > - 2 Marvell 88W8864 radios
> > - 1 USB 3.0 port
> > - 1 USB 2.0/eSATAp port
> > - 2 Ethernet interfaces connected to a 88E6176 switch (1x WAN + 4x LAN)
> > - 128MB NAND flash
> > - 512MB RAM
> >
> > Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> >
> > ---
> > Changes since v1: added DSA support
> > ---
> > The only difference between the two boards is the radio configuration
> > (2x2 vs 3x3), so everything except the leds (to be named properly)
> > is in the dtsi file. When the wireless driver will be submitted
> > upstream, the powertables (calibration data) will end up in the board
> > specific files, tho.
>
> it seems that you missed my comment about removing bootargs and just using
> stdout-path = "serial0:115200n8";
>
> If you agree and if there is no remark about the DSA part from Andrew, I can
> take car of it while applying your patch on mvebu/dt.
DSA looks fine
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
>
>
> Thanks,
>
> Gregory
>
> [...]
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
>
> [...]
>
> > + chosen {
> > + bootargs = "console=ttyS0,115200";
> > + stdout-path = &uart0;
> Just here
> > + };
>
>
> [...]
> --
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Imre Kaloz <kaloz-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCHv2] ARM: mvebu: add support for the new Aramda 385 based Linksys boards
Date: Mon, 25 May 2015 16:08:40 +0200 [thread overview]
Message-ID: <20150525140840.GA8883@lunn.ch> (raw)
In-Reply-To: <55631C6E.8050700-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
On Mon, May 25, 2015 at 02:58:22PM +0200, Gregory CLEMENT wrote:
> Hi Imre,
>
> On 20/05/2015 23:14, Imre Kaloz wrote:
> > This patch adds support for the Linksys WRT1200AC (Caiman) and
> > the Linksys WRT1900AC v2 (Cobra).
> >
> > Both boards have:
> >
> > - 2 Marvell 88W8864 radios
> > - 1 USB 3.0 port
> > - 1 USB 2.0/eSATAp port
> > - 2 Ethernet interfaces connected to a 88E6176 switch (1x WAN + 4x LAN)
> > - 128MB NAND flash
> > - 512MB RAM
> >
> > Signed-off-by: Imre Kaloz <kaloz-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
> >
> > ---
> > Changes since v1: added DSA support
> > ---
> > The only difference between the two boards is the radio configuration
> > (2x2 vs 3x3), so everything except the leds (to be named properly)
> > is in the dtsi file. When the wireless driver will be submitted
> > upstream, the powertables (calibration data) will end up in the board
> > specific files, tho.
>
> it seems that you missed my comment about removing bootargs and just using
> stdout-path = "serial0:115200n8";
>
> If you agree and if there is no remark about the DSA part from Andrew, I can
> take car of it while applying your patch on mvebu/dt.
DSA looks fine
Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Thanks
Andrew
>
>
> Thanks,
>
> Gregory
>
> [...]
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi
>
> [...]
>
> > + chosen {
> > + bootargs = "console=ttyS0,115200";
> > + stdout-path = &uart0;
> Just here
> > + };
>
>
> [...]
> --
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-25 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 21:14 [PATCHv2] ARM: mvebu: add support for the new Aramda 385 based Linksys boards Imre Kaloz
2015-05-20 21:14 ` Imre Kaloz
2015-05-25 12:58 ` Gregory CLEMENT
2015-05-25 12:58 ` Gregory CLEMENT
2015-05-25 13:02 ` Imre Kaloz
2015-05-25 13:02 ` Imre Kaloz
2015-05-25 14:08 ` Andrew Lunn [this message]
2015-05-25 14:08 ` Andrew Lunn
2015-05-25 14:47 ` Gregory CLEMENT
2015-05-25 14:47 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525140840.GA8883@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.