All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static
@ 2015-05-21 11:58 Geert Uytterhoeven
  2015-05-22  1:26 ` Simon Horman
  2015-05-25 17:15 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-05-21 11:58 UTC (permalink / raw)
  To: linux-sh

dma_ts_shift[] isn't used outside this source file. All other users use
the definition from arch/arm/mach-shmobile/dma-register.h.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/dma/sh/shdma-r8a73a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/sh/shdma-r8a73a4.c b/drivers/dma/sh/shdma-r8a73a4.c
index 4fb99970a3ea9b56..96ea3828c3eb8213 100644
--- a/drivers/dma/sh/shdma-r8a73a4.c
+++ b/drivers/dma/sh/shdma-r8a73a4.c
@@ -11,7 +11,7 @@
 
 #include "shdma-arm.h"
 
-const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
+static const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
 
 static const struct sh_dmae_slave_config dma_slaves[] = {
 	{
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static
  2015-05-21 11:58 [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static Geert Uytterhoeven
@ 2015-05-22  1:26 ` Simon Horman
  2015-05-25 17:15 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2015-05-22  1:26 UTC (permalink / raw)
  To: linux-sh

On Thu, May 21, 2015 at 01:58:30PM +0200, Geert Uytterhoeven wrote:
> dma_ts_shift[] isn't used outside this source file. All other users use
> the definition from arch/arm/mach-shmobile/dma-register.h.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/dma/sh/shdma-r8a73a4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/shdma-r8a73a4.c b/drivers/dma/sh/shdma-r8a73a4.c
> index 4fb99970a3ea9b56..96ea3828c3eb8213 100644
> --- a/drivers/dma/sh/shdma-r8a73a4.c
> +++ b/drivers/dma/sh/shdma-r8a73a4.c
> @@ -11,7 +11,7 @@
>  
>  #include "shdma-arm.h"
>  
> -const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
> +static const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
>  
>  static const struct sh_dmae_slave_config dma_slaves[] = {
>  	{
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static
  2015-05-21 11:58 [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static Geert Uytterhoeven
  2015-05-22  1:26 ` Simon Horman
@ 2015-05-25 17:15 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-05-25 17:15 UTC (permalink / raw)
  To: linux-sh

On Thu, May 21, 2015 at 01:58:30PM +0200, Geert Uytterhoeven wrote:
> dma_ts_shift[] isn't used outside this source file. All other users use
> the definition from arch/arm/mach-shmobile/dma-register.h.
Applied, thanks

-- 
~Vinod


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-25 17:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 11:58 [PATCH] DMA: shdma: r8a73a4: Make dma_ts_shift[] static Geert Uytterhoeven
2015-05-22  1:26 ` Simon Horman
2015-05-25 17:15 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.