From: Christoffer Dall <christoffer.dall@linaro.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board
Date: Mon, 25 May 2015 22:56:00 +0200 [thread overview]
Message-ID: <20150525205600.GA10659@cbox> (raw)
In-Reply-To: <011b01d096ec$1a395e80$4eac1b80$@samsung.com>
Hi Pavel,
On Mon, May 25, 2015 at 04:09:58PM +0300, Pavel Fedin wrote:
> Hello!
>
> > typedef struct MemMapEntry {
> > @@ -88,6 +90,7 @@ typedef struct VirtBoardInfo {
> > int fdt_size;
> > uint32_t clock_phandle;
> > uint32_t gic_phandle;
> > + uint32_t v2m_phandle;
> > } VirtBoardInfo;
>
> Could you rename v2m_phandle to something more neutral like msi_phandle ? It will also be
> used by GICv3 ITS implementation.
>
That's sort of how to speculate about. Why can't those patches just
rename the variable then? Right now, as the code stands, msi_phandle
would be less clear IMHO.
-Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: eric.auger@linaro.org, qemu-devel@nongnu.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board
Date: Mon, 25 May 2015 22:56:00 +0200 [thread overview]
Message-ID: <20150525205600.GA10659@cbox> (raw)
In-Reply-To: <011b01d096ec$1a395e80$4eac1b80$@samsung.com>
Hi Pavel,
On Mon, May 25, 2015 at 04:09:58PM +0300, Pavel Fedin wrote:
> Hello!
>
> > typedef struct MemMapEntry {
> > @@ -88,6 +90,7 @@ typedef struct VirtBoardInfo {
> > int fdt_size;
> > uint32_t clock_phandle;
> > uint32_t gic_phandle;
> > + uint32_t v2m_phandle;
> > } VirtBoardInfo;
>
> Could you rename v2m_phandle to something more neutral like msi_phandle ? It will also be
> used by GICv3 ITS implementation.
>
That's sort of how to speculate about. Why can't those patches just
rename the variable then? Right now, as the code stands, msi_phandle
would be less clear IMHO.
-Christoffer
next prev parent reply other threads:[~2015-05-25 20:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-24 10:51 [PATCH v3 0/4] Add support for for GICv2m and MSIs to arm-virt Christoffer Dall
2015-05-24 10:51 ` [Qemu-devel] " Christoffer Dall
2015-05-24 10:51 ` [PATCH v3 1/4] target-arm: Add GIC phandle to VirtBoardInfo Christoffer Dall
2015-05-24 10:51 ` [Qemu-devel] " Christoffer Dall
2015-05-26 12:24 ` Eric Auger
2015-05-26 12:24 ` [Qemu-devel] " Eric Auger
2015-05-24 10:51 ` [PATCH v3 2/4] arm_gicv2m: Add GICv2m widget to support MSIs Christoffer Dall
2015-05-24 10:51 ` [Qemu-devel] " Christoffer Dall
2015-05-26 12:24 ` Eric Auger
2015-05-26 12:24 ` [Qemu-devel] " Eric Auger
2015-05-24 10:51 ` [PATCH v3 3/4] target-arm: Extend the gic node properties Christoffer Dall
2015-05-24 10:51 ` [Qemu-devel] " Christoffer Dall
2015-05-26 12:54 ` Eric Auger
2015-05-26 12:54 ` [Qemu-devel] " Eric Auger
2015-05-24 10:51 ` [PATCH v3 4/4] target-arm: Add the GICv2m to the virt board Christoffer Dall
2015-05-24 10:51 ` [Qemu-devel] " Christoffer Dall
2015-05-25 13:09 ` Pavel Fedin
2015-05-25 13:09 ` [Qemu-devel] " Pavel Fedin
2015-05-25 15:01 ` Peter Maydell
2015-05-25 15:01 ` Peter Maydell
2015-05-25 16:25 ` Eric Auger
2015-05-25 16:25 ` Eric Auger
2015-05-26 6:39 ` Pavel Fedin
2015-05-26 6:39 ` Pavel Fedin
2015-05-25 20:56 ` Christoffer Dall [this message]
2015-05-25 20:56 ` Christoffer Dall
2015-05-26 12:54 ` Eric Auger
2015-05-26 12:54 ` [Qemu-devel] " Eric Auger
2015-05-26 12:55 ` Peter Maydell
2015-05-26 12:55 ` [Qemu-devel] " Peter Maydell
2015-05-26 13:07 ` Eric Auger
2015-05-26 13:07 ` [Qemu-devel] " Eric Auger
2015-05-26 13:52 ` Peter Maydell
2015-05-26 13:52 ` [Qemu-devel] " Peter Maydell
2015-05-26 13:54 ` Pavel Fedin
2015-05-26 13:54 ` [Qemu-devel] " Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525205600.GA10659@cbox \
--to=christoffer.dall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.