From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, wkok@cumulusnetworks.com
Subject: Re: [Bridge] [PATCH net-next] bridge: skip fdb add if the port shouldn't learn
Date: Tue, 26 May 2015 10:28:09 -0700 [thread overview]
Message-ID: <20150526102809.5c3e8abc@urahara> (raw)
In-Reply-To: <1432204977-4293-1-git-send-email-nikolay@cumulusnetworks.com>
On Thu, 21 May 2015 03:42:57 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> From: Wilson Kok <wkok@cumulusnetworks.com>
>
> Check in fdb_add_entry() if the source port should learn, similar
> check is used in br_fdb_update.
> Note that new fdb entries which are added manually or
> as local ones are still permitted.
> This patch has been tested by running traffic via a bridge port and
> switching the port's state, also by manually adding/removing entries
> from the bridge's fdb.
>
> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
What is the problem this is trying to solve?
I think user should be allowed to manually add any entry
even if learning.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, wkok@cumulusnetworks.com,
davem@davemloft.net, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn
Date: Tue, 26 May 2015 10:28:09 -0700 [thread overview]
Message-ID: <20150526102809.5c3e8abc@urahara> (raw)
In-Reply-To: <1432204977-4293-1-git-send-email-nikolay@cumulusnetworks.com>
On Thu, 21 May 2015 03:42:57 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> From: Wilson Kok <wkok@cumulusnetworks.com>
>
> Check in fdb_add_entry() if the source port should learn, similar
> check is used in br_fdb_update.
> Note that new fdb entries which are added manually or
> as local ones are still permitted.
> This patch has been tested by running traffic via a bridge port and
> switching the port's state, also by manually adding/removing entries
> from the bridge's fdb.
>
> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
What is the problem this is trying to solve?
I think user should be allowed to manually add any entry
even if learning.
next prev parent reply other threads:[~2015-05-26 17:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:42 [Bridge] [PATCH net-next] bridge: skip fdb add if the port shouldn't learn Nikolay Aleksandrov
2015-05-21 10:42 ` Nikolay Aleksandrov
2015-05-25 2:59 ` [Bridge] " David Miller
2015-05-25 2:59 ` David Miller
2015-05-25 11:35 ` [Bridge] " Nikolay Aleksandrov
2015-05-25 11:35 ` Nikolay Aleksandrov
2015-05-25 11:41 ` [Bridge] " Nikolay Aleksandrov
2015-05-25 11:41 ` Nikolay Aleksandrov
2015-05-25 13:39 ` [Bridge] [PATCH net-next v2] " Nikolay Aleksandrov
2015-05-25 13:39 ` Nikolay Aleksandrov
2015-05-26 17:28 ` Stephen Hemminger [this message]
2015-05-26 17:28 ` [PATCH net-next] " Stephen Hemminger
2015-05-27 7:05 ` [Bridge] " Nikolay Aleksandrov
2015-05-27 7:05 ` Nikolay Aleksandrov
2015-05-27 7:59 ` [Bridge] " Scott Feldman
2015-05-27 7:59 ` Scott Feldman
2015-05-27 8:35 ` [Bridge] " Nikolay Aleksandrov
2015-05-27 8:35 ` Nikolay Aleksandrov
2015-05-27 16:01 ` [Bridge] " Scott Feldman
2015-05-27 16:01 ` Scott Feldman
2015-05-27 16:14 ` [Bridge] " Nikolay Aleksandrov
2015-05-27 16:14 ` Nikolay Aleksandrov
2015-05-27 20:41 ` [Bridge] " Scott Feldman
2015-05-27 20:41 ` Scott Feldman
2015-06-02 17:14 ` [Bridge] " roopa
2015-06-02 17:14 ` roopa
2015-06-03 5:57 ` [Bridge] " Scott Feldman
2015-06-03 5:57 ` Scott Feldman
2015-06-04 8:14 ` [Bridge] " Nikolay Aleksandrov
2015-06-04 8:14 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526102809.5c3e8abc@urahara \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.