From: Christoph Hellwig <hch@lst.de>
To: device-mapper development <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@canonical.com>,
Al@redhat.com, Christoph Hellwig <hch@lst.de>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Oleg@redhat.com, Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Kent@redhat.com, Overstreet <kent.overstreet@gmail.com>,
Nitin Gupta <ngupta@vflare.org>, Drokin <oleg.drokin@intel.com>,
Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <dchinner@redhat.com>, Ming Lin <mlin@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>
Subject: Re: [dm-devel] [PATCH v4 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Wed, 27 May 2015 10:20:18 +0200 [thread overview]
Message-ID: <20150527082018.GB25575@lst.de> (raw)
In-Reply-To: <20150527004022.GD31182@agk-dp.fab.redhat.com>
On Wed, May 27, 2015 at 01:40:22AM +0100, Alasdair G Kergon wrote:
> It does sometimes make a significant difference to device-mapper stacks.
> DM only uses it for performance reasons - it can already split bios when
> it needs to. I tried to remove merge_bvec_fn from DM several years ago but
> couldn't because of the adverse performance impact of lots of splitting activity.
Does it still? Since the move to immutable biovecs the bio splits are
pretty cheap now, but I'd really like to see this verified by benchmarks.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: device-mapper development <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@canonical.com>,
Al@redhat.com, Christoph Hellwig <hch@lst.de>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Oleg@redhat.com, Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Kent@redhat.com, Overstreet <kent.overstreet@gmail.com>,
Nitin Gupta <ngupta@vflare.org>, Drokin <oleg.drokin@intel.com>,
Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <dchinner@redhat.com>, Ming Lin <mlin@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
drbd-user@lists.linbit.com
Subject: Re: [Drbd-dev] [dm-devel] [PATCH v4 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Wed, 27 May 2015 10:20:18 +0200 [thread overview]
Message-ID: <20150527082018.GB25575@lst.de> (raw)
In-Reply-To: <20150527004022.GD31182@agk-dp.fab.redhat.com>
On Wed, May 27, 2015 at 01:40:22AM +0100, Alasdair G Kergon wrote:
> It does sometimes make a significant difference to device-mapper stacks.
> DM only uses it for performance reasons - it can already split bios when
> it needs to. I tried to remove merge_bvec_fn from DM several years ago but
> couldn't because of the adverse performance impact of lots of splitting activity.
Does it still? Since the move to immutable biovecs the bio splits are
pretty cheap now, but I'd really like to see this verified by benchmarks.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: device-mapper development <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@canonical.com>,
Al@redhat.com, Christoph Hellwig <hch@lst.de>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Oleg@redhat.com, Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Kent@redhat.com, Overstreet <kent.overstreet@gmail.com>,
Nitin Gupta <ngupta@vflare.org>, Drokin <oleg.drokin@intel.com>,
Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <dchinner@redhat.com>, Ming Lin <mlin@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
drbd-user@lists.linbit.com
Subject: Re: [dm-devel] [PATCH v4 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Wed, 27 May 2015 10:20:18 +0200 [thread overview]
Message-ID: <20150527082018.GB25575@lst.de> (raw)
In-Reply-To: <20150527004022.GD31182@agk-dp.fab.redhat.com>
On Wed, May 27, 2015 at 01:40:22AM +0100, Alasdair G Kergon wrote:
> It does sometimes make a significant difference to device-mapper stacks.
> DM only uses it for performance reasons - it can already split bios when
> it needs to. I tried to remove merge_bvec_fn from DM several years ago but
> couldn't because of the adverse performance impact of lots of splitting activity.
Does it still? Since the move to immutable biovecs the bio splits are
pretty cheap now, but I'd really like to see this verified by benchmarks.
next prev parent reply other threads:[~2015-05-27 8:20 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 18:18 [PATCH v4 00/11] simplify block layer based on immutable biovecs Ming Lin
2015-05-22 18:18 ` [PATCH v4 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-22 18:18 ` [Drbd-dev] " Ming Lin
2015-05-25 5:46 ` NeilBrown
2015-05-25 5:46 ` [Drbd-dev] " NeilBrown
2015-05-26 14:36 ` Mike Snitzer
2015-05-26 14:36 ` [Drbd-dev] " Mike Snitzer
2015-05-26 15:02 ` Ming Lin
2015-05-26 15:02 ` [Drbd-dev] " Ming Lin
2015-05-26 15:34 ` Alasdair G Kergon
2015-05-26 15:34 ` Alasdair G Kergon
2015-05-26 15:34 ` [Drbd-dev] " Alasdair G Kergon
2015-05-26 23:06 ` NeilBrown
2015-05-26 23:06 ` [Drbd-dev] " NeilBrown
2015-05-27 0:40 ` [dm-devel] " Alasdair G Kergon
2015-05-27 0:40 ` [Drbd-dev] " Alasdair G Kergon
2015-05-27 8:20 ` Christoph Hellwig [this message]
2015-05-27 8:20 ` Christoph Hellwig
2015-05-27 8:20 ` [Drbd-dev] " Christoph Hellwig
2015-05-26 16:04 ` Mike Snitzer
2015-05-26 16:04 ` [Drbd-dev] " Mike Snitzer
2015-05-26 17:17 ` Ming Lin
2015-05-26 17:17 ` [Drbd-dev] " Ming Lin
[not found] ` <20150526160400.GB4715-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-27 23:42 ` Ming Lin
2015-05-27 23:42 ` Ming Lin
2015-05-27 23:42 ` [Drbd-dev] " Ming Lin
2015-05-28 0:36 ` Alasdair G Kergon
2015-05-28 0:36 ` [Drbd-dev] " Alasdair G Kergon
[not found] ` <20150528003627.GD32216-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2015-05-28 5:54 ` Ming Lin
2015-05-28 5:54 ` Ming Lin
2015-05-28 5:54 ` [Drbd-dev] " Ming Lin
2015-05-29 7:05 ` Ming Lin
2015-05-29 7:05 ` Ming Lin
2015-05-29 7:05 ` [Drbd-dev] " Ming Lin
2015-05-29 15:15 ` Mike Snitzer
2015-05-29 15:15 ` [Drbd-dev] " Mike Snitzer
2015-06-01 6:02 ` Ming Lin
2015-06-01 6:02 ` Ming Lin
2015-06-01 6:02 ` [Drbd-dev] " Ming Lin
2015-06-02 20:59 ` Ming Lin
2015-06-02 20:59 ` Ming Lin
2015-06-02 20:59 ` [Drbd-dev] " Ming Lin
[not found] ` <CAF1ivSY_7M1OhrMuXg0OKu7BPy=SbTHSHCk+2q6vfEVgvJL8YA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-04 21:06 ` Mike Snitzer
2015-06-04 21:06 ` Mike Snitzer
2015-06-04 21:06 ` [Drbd-dev] " Mike Snitzer
2015-06-04 22:21 ` Ming Lin
2015-06-04 22:21 ` [Drbd-dev] " Ming Lin
2015-06-05 0:06 ` Mike Snitzer
2015-06-05 0:06 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150605000636.GA24611-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-05 5:21 ` Ming Lin
2015-06-05 5:21 ` Ming Lin
2015-06-05 5:21 ` [Drbd-dev] " Ming Lin
[not found] ` <20150604210617.GA23710-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-09 6:09 ` Ming Lin
2015-06-09 6:09 ` Ming Lin
2015-06-09 6:09 ` [Drbd-dev] " Ming Lin
2015-06-10 21:20 ` Ming Lin
2015-06-10 21:20 ` Ming Lin
2015-06-10 21:20 ` [Drbd-dev] " Ming Lin
[not found] ` <CAF1ivSbo456n+1JxDp7eAHAgKs5qBOcomN4N9hhCEXmy8i4nPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-10 21:46 ` Mike Snitzer
2015-06-10 21:46 ` Mike Snitzer
2015-06-10 21:46 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150610214611.GA744-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-10 22:06 ` Ming Lin
2015-06-10 22:06 ` Ming Lin
2015-06-10 22:06 ` [Drbd-dev] " Ming Lin
[not found] ` <CAF1ivSbvX1HooUBk-vB3vXGFbocKYimr=YSkLivAV_nSSMHxzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-12 5:49 ` Ming Lin
2015-06-12 5:49 ` Ming Lin
2015-06-12 5:49 ` [Drbd-dev] " Ming Lin
2015-06-18 5:27 ` Ming Lin
2015-06-18 5:27 ` Ming Lin
2015-06-18 5:27 ` [Drbd-dev] " Ming Lin
2015-05-22 18:18 ` [PATCH v4 02/11] block: simplify bio_add_page() Ming Lin
2015-05-22 18:18 ` [PATCH v4 03/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-22 18:18 ` [PATCH v4 04/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-22 18:18 ` [PATCH v4 05/11] block: remove split code in blkdev_issue_discard Ming Lin
2015-05-22 18:18 ` [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-25 5:48 ` NeilBrown
2015-05-25 7:03 ` Ming Lin
2015-05-25 7:54 ` NeilBrown
2015-05-25 14:17 ` Christoph Hellwig
2015-05-26 14:33 ` Ming Lin
2015-05-26 22:32 ` Ming Lin
2015-05-26 23:03 ` NeilBrown
2015-05-26 23:42 ` Ming Lin
2015-05-27 0:38 ` NeilBrown
2015-05-27 8:15 ` Christoph Hellwig
2015-05-22 18:18 ` [PATCH v4 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-22 18:18 ` [PATCH v4 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-22 18:18 ` [Drbd-dev] " Ming Lin
2015-05-25 5:49 ` NeilBrown
2015-05-25 5:49 ` [Drbd-dev] " NeilBrown
2015-05-25 14:04 ` Christoph Hellwig
2015-05-25 14:04 ` [Drbd-dev] " Christoph Hellwig
2015-05-25 15:02 ` Ilya Dryomov
2015-05-25 15:02 ` [Drbd-dev] " Ilya Dryomov
2015-05-25 15:08 ` Christoph Hellwig
2015-05-25 15:08 ` [Drbd-dev] " Christoph Hellwig
2015-05-25 15:19 ` Ilya Dryomov
2015-05-25 15:19 ` [Drbd-dev] " Ilya Dryomov
2015-05-25 15:35 ` Alex Elder
2015-05-25 15:35 ` [Drbd-dev] " Alex Elder
2015-05-22 18:18 ` [PATCH v4 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-22 18:18 ` [PATCH v4 10/11] block: remove bio_get_nr_vecs() Ming Lin
2015-05-22 18:18 ` [PATCH v4 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-05-23 14:15 ` [PATCH v4 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-24 7:37 ` Ming Lin
2015-05-25 13:51 ` Christoph Hellwig
2015-05-29 6:39 ` Ming Lin
2015-06-01 6:15 ` Ming Lin
2015-06-03 6:57 ` Christoph Hellwig
2015-06-03 13:28 ` Jeff Moyer
2015-06-03 17:06 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527082018.GB25575@lst.de \
--to=hch@lst.de \
--cc=Al@redhat.com \
--cc=Kent@redhat.com \
--cc=Oleg@redhat.com \
--cc=agk@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=axboe@kernel.dk \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dpark@posteo.net \
--cc=drbd-dev@lists.linbit.com \
--cc=geoff@infradead.org \
--cc=hch@infradead.org \
--cc=jim@jtan.com \
--cc=jkosina@suse.cz \
--cc=josh.h.morris@us.ibm.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mlin@kernel.org \
--cc=ngupta@vflare.org \
--cc=oleg.drokin@intel.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.