All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mathias Nyman
	<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/6] xhci: probe phy before add usb_hcd
Date: Wed, 27 May 2015 07:18:43 -0500	[thread overview]
Message-ID: <20150527121843.GA8611@saruman.tx.rr.com> (raw)
In-Reply-To: <1432727283-20303-4-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 504 bytes --]

On Wed, May 27, 2015 at 07:48:00PM +0800, chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> From: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> 
> find the phy driver before add primary usb_hcd to avoid acessing
> xHCI register which may hangup the system when the phy is not loaded
> yet and the related powers or clocks put in phy driver are not
> enabled.

it seems like the same clock is needed by PHY and XHCI. This patch looks
incorrect.

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 200 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] xhci: probe phy before add usb_hcd
Date: Wed, 27 May 2015 07:18:43 -0500	[thread overview]
Message-ID: <20150527121843.GA8611@saruman.tx.rr.com> (raw)
In-Reply-To: <1432727283-20303-4-git-send-email-chunfeng.yun@mediatek.com>

On Wed, May 27, 2015 at 07:48:00PM +0800, chunfeng.yun at mediatek.com wrote:
> From: Chunfeng Yun <chunfeng.yun@mediatek.com>
> 
> find the phy driver before add primary usb_hcd to avoid acessing
> xHCI register which may hangup the system when the phy is not loaded
> yet and the related powers or clocks put in phy driver are not
> enabled.

it seems like the same clock is needed by PHY and XHCI. This patch looks
incorrect.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150527/5a79bb54/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Felipe Balbi <balbi@ti.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-usb@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 3/6] xhci: probe phy before add usb_hcd
Date: Wed, 27 May 2015 07:18:43 -0500	[thread overview]
Message-ID: <20150527121843.GA8611@saruman.tx.rr.com> (raw)
In-Reply-To: <1432727283-20303-4-git-send-email-chunfeng.yun@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Wed, May 27, 2015 at 07:48:00PM +0800, chunfeng.yun@mediatek.com wrote:
> From: Chunfeng Yun <chunfeng.yun@mediatek.com>
> 
> find the phy driver before add primary usb_hcd to avoid acessing
> xHCI register which may hangup the system when the phy is not loaded
> yet and the related powers or clocks put in phy driver are not
> enabled.

it seems like the same clock is needed by PHY and XHCI. This patch looks
incorrect.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-05-27 12:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 11:47 [PATCH 0/6] Mediatek xHCI support chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w
2015-05-27 11:47 ` chunfeng.yun
2015-05-27 11:47 ` chunfeng.yun at mediatek.com
2015-05-27 11:47 ` [PATCH 1/6] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs chunfeng.yun
2015-05-27 11:47   ` chunfeng.yun
2015-05-27 11:47   ` chunfeng.yun at mediatek.com
2015-05-27 11:47 ` [PATCH 2/6] dt-bindings: Add a binding for Mediatek xHCI host controller chunfeng.yun
2015-05-27 11:47   ` chunfeng.yun
2015-05-27 11:47   ` chunfeng.yun at mediatek.com
2015-05-27 11:48 ` [PATCH 4/6] usb: phy: add usb3.0 phy driver for mt65xx SoCs chunfeng.yun
2015-05-27 11:48   ` chunfeng.yun
2015-05-27 11:48   ` chunfeng.yun at mediatek.com
     [not found]   ` <1432727283-20303-5-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-06-01 16:18     ` Felipe Balbi
2015-06-01 16:18       ` Felipe Balbi
2015-06-01 16:18       ` Felipe Balbi
2015-05-27 11:48 ` [PATCH 5/6] xhci: mediatek: support MTK xHCI host controller chunfeng.yun
2015-05-27 11:48   ` chunfeng.yun
2015-05-27 11:48   ` chunfeng.yun at mediatek.com
     [not found] ` <1432727283-20303-1-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-27 11:48   ` [PATCH 3/6] xhci: probe phy before add usb_hcd chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w
2015-05-27 11:48     ` chunfeng.yun
2015-05-27 11:48     ` chunfeng.yun at mediatek.com
     [not found]     ` <1432727283-20303-4-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-27 12:18       ` Felipe Balbi [this message]
2015-05-27 12:18         ` Felipe Balbi
2015-05-27 12:18         ` Felipe Balbi
     [not found]         ` <20150527121843.GA8611-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-06-01 14:52           ` Yingjoe Chen
2015-06-01 14:52             ` Yingjoe Chen
2015-06-01 14:52             ` Yingjoe Chen
2015-06-01 15:17             ` Mathias Nyman
2015-06-01 15:17               ` Mathias Nyman
2015-06-01 15:17               ` Mathias Nyman
     [not found]               ` <556C7770.70506-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-02  4:00                 ` Roger Quadros
2015-06-02  4:00                   ` Roger Quadros
2015-06-02  4:00                   ` Roger Quadros
2015-05-27 11:48   ` [PATCH 6/6] arm64: dts: mediatek: add xHCI & usb phy for mt8173 chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w
2015-05-27 11:48     ` chunfeng.yun
2015-05-27 11:48     ` chunfeng.yun at mediatek.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150527121843.GA8611@saruman.tx.rr.com \
    --to=balbi-l0cymroini0@public.gmane.org \
    --cc=chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.