From: Greg KH <gregkh@linuxfoundation.org>
To: Abhishek Bist <ishubist@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()
Date: Wed, 27 May 2015 08:00:05 -0700 [thread overview]
Message-ID: <20150527150005.GA888@kroah.com> (raw)
In-Reply-To: <1432734555-6797-1-git-send-email-ishubist@gmail.com>
On Wed, May 27, 2015 at 07:19:15PM +0530, Abhishek Bist wrote:
> This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not
> being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete
> function from kernel mainline.
Please properly wrap your changelog lines at 72 columns.
> Signed-off-by: Abhishek Bist <ishubist@gmail.com>
> ---
> include/linux/usb/hcd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index 68b1e83..c9aa779 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
> extern struct mutex usb_bus_list_lock;
> extern wait_queue_head_t usb_kill_urb_queue;
>
> -extern int usb_find_interface_driver(struct usb_device *dev,
> - struct usb_interface *interface);
Good catch, care to fix up the wording in your changelog and resend
this?
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-27 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 13:49 [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver() Abhishek Bist
2015-05-27 15:00 ` Greg KH [this message]
2015-05-27 15:00 ` Greg KH
2015-05-27 15:37 ` Paul Bolle
2015-05-27 18:24 ` [PATCH] " Abhishek Bist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527150005.GA888@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ishubist@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.