From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Daniel Borkmann' <daniel@iogearbox.net>,
Neil Horman <nhorman@tuxdriver.com>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
Vlad Yasevich <vyasevich@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket
Date: Wed, 27 May 2015 17:04:40 +0000 [thread overview]
Message-ID: <20150527170440.GA15308@obsidianresearch.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB40E15@AcuExch.aculab.com>
On Wed, May 27, 2015 at 04:41:18PM +0000, David Laight wrote:
> The code will be sleeping in kernel_accept() and later calls
> kernel_getpeername().
> The code is used for both TCP and SCTP and this part is common (using
> the TCP semantics).
getpeername uses a different flow, it calls into inet6_getname which
will always return the AF_INET6 version.
The call to sctp_v6_addr_to_user after is to support the v6->v4 coversion
when SCTP_I_WANT_MAPPED_V4_ADDR=0, it will never do the broken v4->v6
conversion.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Daniel Borkmann' <daniel@iogearbox.net>,
Neil Horman <nhorman@tuxdriver.com>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
Vlad Yasevich <vyasevich@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket
Date: Wed, 27 May 2015 11:04:40 -0600 [thread overview]
Message-ID: <20150527170440.GA15308@obsidianresearch.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB40E15@AcuExch.aculab.com>
On Wed, May 27, 2015 at 04:41:18PM +0000, David Laight wrote:
> The code will be sleeping in kernel_accept() and later calls
> kernel_getpeername().
> The code is used for both TCP and SCTP and this part is common (using
> the TCP semantics).
getpeername uses a different flow, it calls into inet6_getname which
will always return the AF_INET6 version.
The call to sctp_v6_addr_to_user after is to support the v6->v4 coversion
when SCTP_I_WANT_MAPPED_V4_ADDR=0, it will never do the broken v4->v6
conversion.
Jason
next prev parent reply other threads:[~2015-05-27 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:30 [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket Jason Gunthorpe
2015-05-26 23:30 ` Jason Gunthorpe
2015-05-27 8:11 ` Daniel Borkmann
2015-05-27 8:11 ` Daniel Borkmann
2015-05-27 9:06 ` David Laight
2015-05-27 9:34 ` Daniel Borkmann
2015-05-27 9:34 ` Daniel Borkmann
2015-05-27 10:11 ` David Laight
2015-05-27 15:32 ` Jason Gunthorpe
2015-05-27 15:32 ` Jason Gunthorpe
2015-05-27 16:16 ` David Laight
2015-05-27 16:31 ` Jason Gunthorpe
2015-05-27 16:31 ` Jason Gunthorpe
2015-05-27 16:41 ` David Laight
2015-05-27 17:04 ` Jason Gunthorpe [this message]
2015-05-27 17:04 ` Jason Gunthorpe
2015-05-28 8:58 ` David Laight
2015-05-27 14:06 ` Neil Horman
2015-05-27 14:06 ` Neil Horman
2015-05-27 18:17 ` David Miller
2015-05-27 18:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527170440.GA15308@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=David.Laight@ACULAB.COM \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.