From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@kernel.dk, Boaz Harrosh <boaz@plexistor.com>,
neilb@suse.de, Dave Chinner <david@fromorbit.com>,
Lv Zheng <lv.zheng@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
hch@lst.de, sfr@canb.auug.org.au, linux-nvdimm@lists.01.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Robert Moore <robert.moore@intel.com>,
mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com,
Nicholas Moulin <nicholas.w.moulin@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Vishal Verma <vishal.l.verma@linux.intel.com>,
Jens Axboe <axboe@fb.com>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support
Date: Thu, 28 May 2015 10:51:24 +0200 [thread overview]
Message-ID: <20150528085124.GA26120@lst.de> (raw)
In-Reply-To: <20150527210155.17965.74864.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, May 27, 2015 at 06:24:42PM -0400, Dan Williams wrote:
> Jens, please pull from...
>
> git://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm tags/libnd-for-jens
I don't really think it's quite ready. I don't have time to sort through
the giant steaming pile for now, but there are a few things here:
- stong NAK for the linker wrapping abuse in the test module
- you must run the ioctls past the linux-api list at least
- please make sure the legacy e820 changes are properly tested. I could
take of it, but not until Wednesday next week as I'm travelling right
now.
Also a little nitpick on naming: why is this still nd instead of the
widely used nvdimm? Also as very little of it is related to block drivers
and a lot is management it should be under drivers/ not drivers/block/
I think.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@kernel.dk, Boaz Harrosh <boaz@plexistor.com>,
neilb@suse.de, Dave Chinner <david@fromorbit.com>,
Lv Zheng <lv.zheng@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
hch@lst.de, sfr@canb.auug.org.au, linux-nvdimm@ml01.01.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Robert Moore <robert.moore@intel.com>,
mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com,
Nicholas Moulin <nicholas.w.moulin@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Vishal Verma <vishal.l.verma@linux.intel.com>,
Jens Axboe <axboe@fb.com>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support
Date: Thu, 28 May 2015 10:51:24 +0200 [thread overview]
Message-ID: <20150528085124.GA26120@lst.de> (raw)
In-Reply-To: <20150527210155.17965.74864.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, May 27, 2015 at 06:24:42PM -0400, Dan Williams wrote:
> Jens, please pull from...
>
> git://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm tags/libnd-for-jens
I don't really think it's quite ready. I don't have time to sort through
the giant steaming pile for now, but there are a few things here:
- stong NAK for the linker wrapping abuse in the test module
- you must run the ioctls past the linux-api list at least
- please make sure the legacy e820 changes are properly tested. I could
take of it, but not until Wednesday next week as I'm travelling right
now.
Also a little nitpick on naming: why is this still nd instead of the
widely used nvdimm? Also as very little of it is related to block drivers
and a lot is management it should be under drivers/ not drivers/block/
I think.
next prev parent reply other threads:[~2015-05-28 8:51 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 22:24 [GIT PULL v4 00/21] libnd: non-volatile memory device support Dan Williams
2015-05-27 22:24 ` Dan Williams
2015-05-27 22:24 ` [PATCH v4 01/21] e820, efi: add ACPI 6.0 persistent memory types Dan Williams
2015-05-27 22:24 ` Dan Williams
2015-05-27 22:24 ` [PATCH v4 02/21] libnd, nfit: initial libnd infrastructure and NFIT support Dan Williams
2015-05-27 22:24 ` Dan Williams
2015-05-27 22:24 ` [PATCH v4 03/21] libnd: control character device and libnd bus sysfs attributes Dan Williams
2015-05-27 22:24 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 04/21] libnd, nfit: dimm/memory-devices Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 05/21] libnd: control (ioctl) messages for libnd bus and dimm devices Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 06/21] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 07/21] libnd, nfit: regions (block-data-window, persistent memory, volatile memory) Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 08/21] libnd: support for legacy (non-aliasing) nvdimms Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 09/21] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 10/21] pmem: Dynamically allocate partition numbers Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 11/21] libnd, nfit: add interleave-set state-tracking infrastructure Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 12/21] libnd: namespace indices: read and validate Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 13/21] libnd: pmem label sets and namespace instantiation Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:25 ` [PATCH v4 14/21] libnd: blk labels " Dan Williams
2015-05-27 22:25 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 15/21] libnd: write pmem label set Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 16/21] libnd: write blk " Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 17/21] libnd: infrastructure for btt devices Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 18/21] nd_btt: atomic sector updates Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 19/21] libnd, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 20/21] nfit-test: manufactured NFITs for interface development Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:26 ` [PATCH v4 21/21] libnd: Non-Volatile Devices Dan Williams
2015-05-27 22:26 ` Dan Williams
2015-05-27 22:36 ` [GIT PULL v4 00/21] libnd: non-volatile memory device support Rafael J. Wysocki
2015-05-27 22:36 ` Rafael J. Wysocki
2015-05-27 22:36 ` Rafael J. Wysocki
2015-05-27 22:52 ` Dan Williams
2015-05-27 22:52 ` Dan Williams
2015-05-27 22:52 ` Dan Williams
2015-05-27 23:17 ` Rafael J. Wysocki
2015-05-27 23:17 ` Rafael J. Wysocki
2015-05-27 23:17 ` Rafael J. Wysocki
2015-05-28 0:34 ` Dan Williams
2015-05-28 0:34 ` Dan Williams
2015-05-28 0:34 ` Dan Williams
2015-05-28 0:42 ` Rafael J. Wysocki
2015-05-28 0:42 ` Rafael J. Wysocki
2015-05-28 0:42 ` Rafael J. Wysocki
2015-05-28 0:55 ` Dan Williams
2015-05-28 0:55 ` Dan Williams
2015-05-28 0:55 ` Dan Williams
2015-05-28 1:01 ` Rafael J. Wysocki
2015-05-28 1:01 ` Rafael J. Wysocki
2015-05-28 1:01 ` Rafael J. Wysocki
2015-05-28 5:21 ` Williams, Dan J
2015-05-28 5:21 ` Williams, Dan J
2015-05-28 5:21 ` Williams, Dan J
2015-05-28 8:51 ` Christoph Hellwig [this message]
2015-05-28 8:51 ` Christoph Hellwig
2015-05-28 14:55 ` Dan Williams
2015-05-28 14:55 ` Dan Williams
2015-05-28 14:55 ` Dan Williams
2015-06-03 6:55 ` Christoph Hellwig
2015-06-03 6:55 ` Christoph Hellwig
2015-06-03 6:55 ` Christoph Hellwig
2015-06-03 7:02 ` Dan Williams
2015-06-03 7:02 ` Dan Williams
2015-06-03 7:02 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528085124.GA26120@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jmoyer@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=nicholas.w.moulin@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vishal.l.verma@linux.intel.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.