* Re: [PATCHv3] pktgen: Convert return type of process_ipsec to bool
[not found] <1432786265-31021-1-git-send-email-xerofoify@gmail.com>
@ 2015-05-28 10:11 ` Jesper Dangaard Brouer
0 siblings, 0 replies; only message in thread
From: Jesper Dangaard Brouer @ 2015-05-28 10:11 UTC (permalink / raw)
To: Nicholas Krause
Cc: davem, edumazet, ast, stephen, fabf, joe, sd, netdev,
linux-kernel, brouer
On Thu, 28 May 2015 00:11:05 -0400
Nicholas Krause <xerofoify@gmail.com> wrote:
> This converts the function, process_ipsec to the
> return type of bool due to only returning either
> one or zero.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> v3
> Move the v2 changes below the sign off line for this patch.
> v2
> Change incorrect patch subject and make commit message
> clearer
> net/core/pktgen.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 508155b..33bdb76 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2587,7 +2587,7 @@ static void free_SAs(struct pktgen_dev *pkt_dev)
> }
> }
>
> -static int process_ipsec(struct pktgen_dev *pkt_dev,
> +static bool process_ipsec(struct pktgen_dev *pkt_dev,
> struct sk_buff *skb, __be16 protocol)
When doing this change, could you please align the above line to the
open parenthesis of process_ipsec (even-though it was also misaligned
before).
scripts/checkpatch.pl will tell you:
CHECK: Alignment should match open parenthesis
Did anyone tell you that kernel developers nitpick? ;-)
And usually you don't need to Cc the "main" Linux Kernel Mailing List
(linux-kernel@vger.kernel.org) with a trivial patch like this. Sending
it to the network developers should be enough (netdev@vger.kernel.org).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] only message in thread