All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, berto@igalia.com, mst@redhat.com,
	qemu-devel@nongnu.org, armbru@redhat.com,
	mdroth@linux.vnet.ibm.com, mreitz@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 0/2] Use bool for QBool
Date: Thu, 28 May 2015 15:54:12 -0400	[thread overview]
Message-ID: <20150528155412.18341ee7@redhat.com> (raw)
In-Reply-To: <1431728700-18055-1-git-send-email-eblake@redhat.com>

On Fri, 15 May 2015 16:24:58 -0600
Eric Blake <eblake@redhat.com> wrote:

> Passing around an 'int' for a QBool type is weird, when we already
> use a C99 compiler and have a sane 'bool' that does just fine.
> 
> I half-debated sending this through qemu-trivial, but think it
> better belongs through the QMP tree.  There turned out to be few
> enough clients that I grouped it into two patches touching a number
> of files each; but I'm also okay with splitting into finer-grained
> patches that focus on fewer files at a time if that is desired.
> 
> Eric Blake (2):
>   qobject: Use 'bool' for qbool
>   qobject: Use 'bool' inside qdict

Applied to the qmp branch, thanks.

> 
>  block/qapi.c                    |  2 +-
>  block/quorum.c                  |  4 ++--
>  block/vvfat.c                   |  4 ++--
>  hmp.c                           | 40 ++++++++++++++++++++--------------------
>  hw/pci/pcie_aer.c               |  4 ++--
>  include/qapi/qmp/qbool.h        |  8 ++++----
>  include/qapi/qmp/qdict.h        |  4 ++--
>  monitor.c                       | 12 ++++++------
>  qapi/qmp-input-visitor.c        |  2 +-
>  qapi/qmp-output-visitor.c       |  2 +-
>  qobject/json-parser.c           |  6 +++---
>  qobject/qbool.c                 |  8 ++++----
>  qobject/qdict.c                 |  8 ++++----
>  qobject/qjson.c                 |  2 +-
>  qom/object.c                    |  4 ++--
>  tests/check-qjson.c             | 11 ++++++-----
>  tests/test-qmp-event.c          |  4 ++--
>  tests/test-qmp-output-visitor.c |  6 +++---
>  util/qemu-option.c              |  2 +-
>  19 files changed, 67 insertions(+), 66 deletions(-)
> 

  parent reply	other threads:[~2015-05-28 22:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 22:24 [Qemu-devel] [PATCH 0/2] Use bool for QBool Eric Blake
2015-05-15 22:24 ` [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool Eric Blake
2015-05-16 13:30   ` Andreas Färber
2015-05-16 17:13     ` Eric Blake
2015-05-18  6:42       ` Markus Armbruster
2015-05-19 12:59   ` Alberto Garcia
2015-06-12  5:35   ` Markus Armbruster
2015-06-12 15:38     ` Eric Blake
2015-05-15 22:25 ` [Qemu-devel] [PATCH 2/2] qobject: Use 'bool' inside qdict Eric Blake
2015-05-19 13:00   ` Alberto Garcia
2015-05-28 19:54 ` Luiz Capitulino [this message]
2015-06-11 17:53   ` [Qemu-devel] [PATCH 0/2] Use bool for QBool Luiz Capitulino
2015-06-16 14:53 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150528155412.18341ee7@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.