Re: [Qemu-devel] [PATCH 0/2] Use bool for QBool

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 28 May 2015 15:54:12 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Fri, 15 May 2015 16:24:58 -0600
> Eric Blake <eblake@redhat.com> wrote:
> 
> > Passing around an 'int' for a QBool type is weird, when we already
> > use a C99 compiler and have a sane 'bool' that does just fine.
> > 
> > I half-debated sending this through qemu-trivial, but think it
> > better belongs through the QMP tree.  There turned out to be few
> > enough clients that I grouped it into two patches touching a number
> > of files each; but I'm also okay with splitting into finer-grained
> > patches that focus on fewer files at a time if that is desired.
> > 
> > Eric Blake (2):
> >   qobject: Use 'bool' for qbool
> >   qobject: Use 'bool' inside qdict
> 
> Applied to the qmp branch, thanks.

Unfortunately, I'm quite busy and won't have time to push this
through my tree. Markus is going to pick up this series soon.

Acked-by: Luiz Capitulino <lcapitulino@redhat.com>

> 
> > 
> >  block/qapi.c                    |  2 +-
> >  block/quorum.c                  |  4 ++--
> >  block/vvfat.c                   |  4 ++--
> >  hmp.c                           | 40 ++++++++++++++++++++--------------------
> >  hw/pci/pcie_aer.c               |  4 ++--
> >  include/qapi/qmp/qbool.h        |  8 ++++----
> >  include/qapi/qmp/qdict.h        |  4 ++--
> >  monitor.c                       | 12 ++++++------
> >  qapi/qmp-input-visitor.c        |  2 +-
> >  qapi/qmp-output-visitor.c       |  2 +-
> >  qobject/json-parser.c           |  6 +++---
> >  qobject/qbool.c                 |  8 ++++----
> >  qobject/qdict.c                 |  8 ++++----
> >  qobject/qjson.c                 |  2 +-
> >  qom/object.c                    |  4 ++--
> >  tests/check-qjson.c             | 11 ++++++-----
> >  tests/test-qmp-event.c          |  4 ++--
> >  tests/test-qmp-output-visitor.c |  6 +++---
> >  util/qemu-option.c              |  2 +-
> >  19 files changed, 67 insertions(+), 66 deletions(-)
> > 
>