All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Kees Cook <keescook@chromium.org>,
	Tony Luck <tony.luck@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Kristen Carlson Accardi <kristen@linux.intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Vinod Koul <vinod.koul@intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hiral Patel <hiralpat@cisco.com>, Suma Ramars <sramars@cisco.com>,
	Brian Uchino <buchino@cisco.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.d>
Subject: Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h
Date: Fri, 29 May 2015 11:21:05 +0200	[thread overview]
Message-ID: <20150529092105.GA30603@gmail.com> (raw)
In-Reply-To: <20150529191847.2d4cb3a7@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
> 
> This may be the place where x86 builds get vmalloc.h implicitly included
> and that tends to hide places where vmalloc() et al are added to files
> but the include of vmalloc.h is forgotten.

Good idea.

Acked-by: Ingo Molnar <mingo@kernel.org>

> Based in Linus' tree of today.
> 
> There are probably more places that need vmalloc.h included, but this passes 64 
> bit and 32 bit allmodconfig builds, so is a place to start.

Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the 
remaining places. People doing randconfig testing will find the rest.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Kees Cook <keescook@chromium.org>,
	Tony Luck <tony.luck@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Kristen Carlson Accardi <kristen@linux.intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Vinod Koul <vinod.koul@intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hiral Patel <hiralpat@cisco.com>, Suma Ramars <sramars@cisco.com>,
	Brian Uchino <buchino@cisco.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	dmaengine@vger.kernel.org, devel@linuxdriverproject.org,
	netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h
Date: Fri, 29 May 2015 11:21:05 +0200	[thread overview]
Message-ID: <20150529092105.GA30603@gmail.com> (raw)
In-Reply-To: <20150529191847.2d4cb3a7@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
> 
> This may be the place where x86 builds get vmalloc.h implicitly included
> and that tends to hide places where vmalloc() et al are added to files
> but the include of vmalloc.h is forgotten.

Good idea.

Acked-by: Ingo Molnar <mingo@kernel.org>

> Based in Linus' tree of today.
> 
> There are probably more places that need vmalloc.h included, but this passes 64 
> bit and 32 bit allmodconfig builds, so is a place to start.

Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the 
remaining places. People doing randconfig testing will find the rest.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Kees Cook <keescook@chromium.org>,
	Tony Luck <tony.luck@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Kristen Carlson Accardi <kristen@linux.intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Vinod Koul <vinod.koul@intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hiral Patel <hiralpat@cisco.com>, Suma Ramars <sramars@cisco.com>,
	Brian Uchino <buchino@cisco.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.d
Subject: Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h
Date: Fri, 29 May 2015 11:21:05 +0200	[thread overview]
Message-ID: <20150529092105.GA30603@gmail.com> (raw)
In-Reply-To: <20150529191847.2d4cb3a7@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Nothing in asm/io.h uses anything from vmalloc.h, so remove the include
> and fix up the build problems in an allmodconfig (64 bit and 32 bit)
> build.
> 
> This may be the place where x86 builds get vmalloc.h implicitly included
> and that tends to hide places where vmalloc() et al are added to files
> but the include of vmalloc.h is forgotten.

Good idea.

Acked-by: Ingo Molnar <mingo@kernel.org>

> Based in Linus' tree of today.
> 
> There are probably more places that need vmalloc.h included, but this passes 64 
> bit and 32 bit allmodconfig builds, so is a place to start.

Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the 
remaining places. People doing randconfig testing will find the rest.

Thanks,

	Ingo

  parent reply	other threads:[~2015-05-29  9:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  9:18 [RFC][PATCH] x86: remove vmalloc.h from asm/io.h Stephen Rothwell
2015-05-29  9:18 ` Stephen Rothwell
2015-05-29  9:18 ` Stephen Rothwell
2015-05-29  9:21 ` Ingo Molnar
2015-05-29  9:21 ` Ingo Molnar [this message]
2015-05-29  9:21   ` Ingo Molnar
2015-05-29  9:21   ` Ingo Molnar
2015-05-29 12:40   ` Stephen Rothwell
2015-05-29 12:40     ` Stephen Rothwell
2015-05-29 12:40     ` Stephen Rothwell
2015-05-29 12:40   ` Stephen Rothwell
2015-05-29 12:43 ` Takashi Iwai
2015-05-29 12:43 ` Takashi Iwai
2015-05-29 12:43   ` Takashi Iwai
2015-05-29 12:43   ` Takashi Iwai
2015-05-29 15:28   ` Stephen Rothwell
2015-05-29 15:28   ` Stephen Rothwell
2015-05-29 15:28     ` Stephen Rothwell
2015-05-29 15:28     ` Stephen Rothwell
2015-06-01 22:59 ` David Miller
2015-06-02  0:19   ` Stephen Rothwell
2015-06-02  0:19   ` Stephen Rothwell
2015-06-02  0:19     ` Stephen Rothwell
2015-06-01 22:59 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2015-05-29  9:18 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529092105.GA30603@gmail.com \
    --to=mingo@kernel.org \
    --cc=JBottomley@odin.com \
    --cc=anton@enomsg.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=buchino@cisco.com \
    --cc=ccross@android.com \
    --cc=david.vrabel@citrix.com \
    --cc=haiyangz@microsoft.com \
    --cc=hiralpat@cisco.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kristen@linux.intel.com \
    --cc=kys@microsoft.com \
    --cc=lenb@kernel.org \
    --cc=mingo@redhat.com \
    --cc=perex@perex.cz \
    --cc=rjw@rjwysocki.net \
    --cc=sfr@canb.auug.org.au \
    --cc=sramars@cisco.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.d \
    --cc=tony.luck@intel.com \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.