All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: dann frazier <dann.frazier@canonical.com>, grub-devel@gnu.org
Subject: Re: [PATCH] arm64/setjmp: Add missing license macro
Date: Sat, 30 May 2015 09:00:00 +0300	[thread overview]
Message-ID: <20150530090000.458bb546@opensuse.site> (raw)
In-Reply-To: <1432225728-14020-1-git-send-email-dann.frazier@canonical.com>

Leif, any comments? You are the author of it, was GRUB_MOD_LICENSE
omission intentional or by accident?

В Thu, 21 May 2015 10:28:48 -0600
dann frazier <dann.frazier@canonical.com> пишет:

> Including the setjmp module in an arm64-efi image will cause it to
> immediately exit with an "incompatible license" error.
> 
> The source file includes a GPLv3+ boilerplate, so fix this by declaring a
> GPLv3+ license using the GRUB_MOD_LICENSE macro.
> 
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
>  grub-core/lib/arm64/setjmp.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/grub-core/lib/arm64/setjmp.S b/grub-core/lib/arm64/setjmp.S
> index adaafe4..eabfd99 100644
> --- a/grub-core/lib/arm64/setjmp.S
> +++ b/grub-core/lib/arm64/setjmp.S
> @@ -17,8 +17,10 @@
>   */
>  
>  #include <grub/symbol.h>
> +#include <grub/dl.h>
>  
>  	.file	"setjmp.S"
> +GRUB_MOD_LICENSE "GPLv3+"
>  	.text
>  
>  /*



  reply	other threads:[~2015-05-30  6:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 16:28 [PATCH] arm64/setjmp: Add missing license macro dann frazier
2015-05-30  6:00 ` Andrei Borzenkov [this message]
2015-06-01 13:25   ` Leif Lindholm
2015-06-01 14:06     ` Vladimir 'phcoder' Serbinenko
2015-06-01 18:31       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150530090000.458bb546@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=dann.frazier@canonical.com \
    --cc=grub-devel@gnu.org \
    --cc=leif.lindholm@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.