* [PATCH] arm64/setjmp: Add missing license macro
@ 2015-05-21 16:28 dann frazier
2015-05-30 6:00 ` Andrei Borzenkov
0 siblings, 1 reply; 5+ messages in thread
From: dann frazier @ 2015-05-21 16:28 UTC (permalink / raw)
To: grub-devel; +Cc: Leif Lindholm
Including the setjmp module in an arm64-efi image will cause it to
immediately exit with an "incompatible license" error.
The source file includes a GPLv3+ boilerplate, so fix this by declaring a
GPLv3+ license using the GRUB_MOD_LICENSE macro.
Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
grub-core/lib/arm64/setjmp.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/grub-core/lib/arm64/setjmp.S b/grub-core/lib/arm64/setjmp.S
index adaafe4..eabfd99 100644
--- a/grub-core/lib/arm64/setjmp.S
+++ b/grub-core/lib/arm64/setjmp.S
@@ -17,8 +17,10 @@
*/
#include <grub/symbol.h>
+#include <grub/dl.h>
.file "setjmp.S"
+GRUB_MOD_LICENSE "GPLv3+"
.text
/*
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64/setjmp: Add missing license macro
2015-05-21 16:28 [PATCH] arm64/setjmp: Add missing license macro dann frazier
@ 2015-05-30 6:00 ` Andrei Borzenkov
2015-06-01 13:25 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Andrei Borzenkov @ 2015-05-30 6:00 UTC (permalink / raw)
To: Leif Lindholm; +Cc: dann frazier, grub-devel
Leif, any comments? You are the author of it, was GRUB_MOD_LICENSE
omission intentional or by accident?
В Thu, 21 May 2015 10:28:48 -0600
dann frazier <dann.frazier@canonical.com> пишет:
> Including the setjmp module in an arm64-efi image will cause it to
> immediately exit with an "incompatible license" error.
>
> The source file includes a GPLv3+ boilerplate, so fix this by declaring a
> GPLv3+ license using the GRUB_MOD_LICENSE macro.
>
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
> grub-core/lib/arm64/setjmp.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/grub-core/lib/arm64/setjmp.S b/grub-core/lib/arm64/setjmp.S
> index adaafe4..eabfd99 100644
> --- a/grub-core/lib/arm64/setjmp.S
> +++ b/grub-core/lib/arm64/setjmp.S
> @@ -17,8 +17,10 @@
> */
>
> #include <grub/symbol.h>
> +#include <grub/dl.h>
>
> .file "setjmp.S"
> +GRUB_MOD_LICENSE "GPLv3+"
> .text
>
> /*
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64/setjmp: Add missing license macro
2015-05-30 6:00 ` Andrei Borzenkov
@ 2015-06-01 13:25 ` Leif Lindholm
2015-06-01 14:06 ` Vladimir 'phcoder' Serbinenko
0 siblings, 1 reply; 5+ messages in thread
From: Leif Lindholm @ 2015-06-01 13:25 UTC (permalink / raw)
To: Andrei Borzenkov; +Cc: dann frazier, grub-devel
On Sat, May 30, 2015 at 09:00:00AM +0300, Andrei Borzenkov wrote:
> Leif, any comments? You are the author of it, was GRUB_MOD_LICENSE
> omission intentional or by accident?
Apologies - entirely accidental.
Can I push Dann's fix?
> В Thu, 21 May 2015 10:28:48 -0600
> dann frazier <dann.frazier@canonical.com> пишет:
>
> > Including the setjmp module in an arm64-efi image will cause it to
> > immediately exit with an "incompatible license" error.
> >
> > The source file includes a GPLv3+ boilerplate, so fix this by declaring a
> > GPLv3+ license using the GRUB_MOD_LICENSE macro.
> >
> > Signed-off-by: dann frazier <dann.frazier@canonical.com>
> > ---
> > grub-core/lib/arm64/setjmp.S | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/grub-core/lib/arm64/setjmp.S b/grub-core/lib/arm64/setjmp.S
> > index adaafe4..eabfd99 100644
> > --- a/grub-core/lib/arm64/setjmp.S
> > +++ b/grub-core/lib/arm64/setjmp.S
> > @@ -17,8 +17,10 @@
> > */
> >
> > #include <grub/symbol.h>
> > +#include <grub/dl.h>
> >
> > .file "setjmp.S"
> > +GRUB_MOD_LICENSE "GPLv3+"
> > .text
> >
> > /*
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64/setjmp: Add missing license macro
2015-06-01 13:25 ` Leif Lindholm
@ 2015-06-01 14:06 ` Vladimir 'phcoder' Serbinenko
2015-06-01 18:31 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2015-06-01 14:06 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
Go ahead
On Jun 1, 2015 3:33 PM, "Leif Lindholm" <leif.lindholm@linaro.org> wrote:
> On Sat, May 30, 2015 at 09:00:00AM +0300, Andrei Borzenkov wrote:
> > Leif, any comments? You are the author of it, was GRUB_MOD_LICENSE
> > omission intentional or by accident?
>
> Apologies - entirely accidental.
>
> Can I push Dann's fix?
>
> > В Thu, 21 May 2015 10:28:48 -0600
> > dann frazier <dann.frazier@canonical.com> пишет:
> >
> > > Including the setjmp module in an arm64-efi image will cause it to
> > > immediately exit with an "incompatible license" error.
> > >
> > > The source file includes a GPLv3+ boilerplate, so fix this by
> declaring a
> > > GPLv3+ license using the GRUB_MOD_LICENSE macro.
> > >
> > > Signed-off-by: dann frazier <dann.frazier@canonical.com>
> > > ---
> > > grub-core/lib/arm64/setjmp.S | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/grub-core/lib/arm64/setjmp.S
> b/grub-core/lib/arm64/setjmp.S
> > > index adaafe4..eabfd99 100644
> > > --- a/grub-core/lib/arm64/setjmp.S
> > > +++ b/grub-core/lib/arm64/setjmp.S
> > > @@ -17,8 +17,10 @@
> > > */
> > >
> > > #include <grub/symbol.h>
> > > +#include <grub/dl.h>
> > >
> > > .file "setjmp.S"
> > > +GRUB_MOD_LICENSE "GPLv3+"
> > > .text
> > >
> > > /*
> >
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: Type: text/html, Size: 2271 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64/setjmp: Add missing license macro
2015-06-01 14:06 ` Vladimir 'phcoder' Serbinenko
@ 2015-06-01 18:31 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2015-06-01 18:31 UTC (permalink / raw)
To: The development of GNU GRUB
On Mon, Jun 01, 2015 at 04:06:07PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Go ahead
Thanks, done.
Apologies for the delay, caused by some toolchains issues I
encountered when doing a test build before pushing. I will follow up
regarding these later.
> On Jun 1, 2015 3:33 PM, "Leif Lindholm" <leif.lindholm@linaro.org> wrote:
>
> > On Sat, May 30, 2015 at 09:00:00AM +0300, Andrei Borzenkov wrote:
> > > Leif, any comments? You are the author of it, was GRUB_MOD_LICENSE
> > > omission intentional or by accident?
> >
> > Apologies - entirely accidental.
> >
> > Can I push Dann's fix?
> >
> > > В Thu, 21 May 2015 10:28:48 -0600
> > > dann frazier <dann.frazier@canonical.com> пишет:
> > >
> > > > Including the setjmp module in an arm64-efi image will cause it to
> > > > immediately exit with an "incompatible license" error.
> > > >
> > > > The source file includes a GPLv3+ boilerplate, so fix this by
> > declaring a
> > > > GPLv3+ license using the GRUB_MOD_LICENSE macro.
> > > >
> > > > Signed-off-by: dann frazier <dann.frazier@canonical.com>
> > > > ---
> > > > grub-core/lib/arm64/setjmp.S | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/grub-core/lib/arm64/setjmp.S
> > b/grub-core/lib/arm64/setjmp.S
> > > > index adaafe4..eabfd99 100644
> > > > --- a/grub-core/lib/arm64/setjmp.S
> > > > +++ b/grub-core/lib/arm64/setjmp.S
> > > > @@ -17,8 +17,10 @@
> > > > */
> > > >
> > > > #include <grub/symbol.h>
> > > > +#include <grub/dl.h>
> > > >
> > > > .file "setjmp.S"
> > > > +GRUB_MOD_LICENSE "GPLv3+"
> > > > .text
> > > >
> > > > /*
> > >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> >
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-01 18:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 16:28 [PATCH] arm64/setjmp: Add missing license macro dann frazier
2015-05-30 6:00 ` Andrei Borzenkov
2015-06-01 13:25 ` Leif Lindholm
2015-06-01 14:06 ` Vladimir 'phcoder' Serbinenko
2015-06-01 18:31 ` Leif Lindholm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.