From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Joe Perches <joe@perches.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"mdcasey@chabloom.com" <mdcasey@chabloom.com>,
"Babu, Viswanathan (V.)" <vbabu3@visteon.com>,
"lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"himangi774@gmail.com" <himangi774@gmail.com>,
"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@visteon.com>,
"kolbeinnkarls@gmail.com" <kolbeinnkarls@gmail.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment
Date: Sun, 31 May 2015 09:26:35 +0900 [thread overview]
Message-ID: <20150531002635.GB23738@kroah.com> (raw)
In-Reply-To: <20150518164242.GB12138@sudip-PC>
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > > setup_timer is used for timer parameter setup rather than direct
> > > > assignment
> > > >
> > > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
> > >
> > > your From: name and Signed-off-by: names are not matching. They should
> > > be same.
> >
> > If there's a specific "From: " in the _body_ of the email,
> > that's true, but the sender email "From: " header and the
> > Signed-off-by: line do not have to match.
> But Greg usually rejects these patches where the sender "From:" header
> and Signed-off-by: doesnot match. Just for example:
>
> https://lkml.org/lkml/2014/11/25/924
Yes, I can't take it where it doesn't match up.
Sometimes I miss it, but when it's pointed out, I will not accept it.
thanks,
greg k-h
next prev parent reply other threads:[~2015-05-31 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:44 [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment DHANAPAL, GNANACHANDRAN (G.)
2015-05-18 16:05 ` Sudip Mukherjee
2015-05-18 16:26 ` Joe Perches
2015-05-18 16:42 ` Sudip Mukherjee
2015-05-31 0:26 ` gregkh [this message]
2015-05-18 17:49 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150531002635.GB23738@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gdhanapa@visteon.com \
--cc=himangi774@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kolbeinnkarls@gmail.com \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdcasey@chabloom.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=vbabu3@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.