* [PATCH v2] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup
@ 2015-05-31 5:39 Dighe, Niranjan (N.)
0 siblings, 0 replies; only message in thread
From: Dighe, Niranjan (N.) @ 2015-05-31 5:39 UTC (permalink / raw)
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, HPDD-discuss@lists.01.org,
andreas.dilger@intel.com, gdonald@gmail.com, uja.ornl@gmail.com,
rd@radekdostal.com, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, Julia.Lawall@lip6.fr, joe@perches.com
From: Niranjan Dighe <ndighe@visteon.com>
Replace kzalloc followed by memcpy by kmemdup. This patch was generated
by 'make coccicheck'
Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
---
drivers/staging/lustre/lustre/obdclass/obd_config.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c
index 0bda9c5..274cae3 100644
--- a/drivers/staging/lustre/lustre/obdclass/obd_config.c
+++ b/drivers/staging/lustre/lustre/obdclass/obd_config.c
@@ -866,29 +866,26 @@ int class_add_profile(int proflen, char *prof, int osclen, char *osc,
INIT_LIST_HEAD(&lprof->lp_list);
LASSERT(proflen == (strlen(prof) + 1));
- lprof->lp_profile = kzalloc(proflen, GFP_NOFS);
+ lprof->lp_profile = kmemdup(prof, proflen, GFP_NOFS);
if (lprof->lp_profile == NULL) {
err = -ENOMEM;
goto free_lprof;
}
- memcpy(lprof->lp_profile, prof, proflen);
LASSERT(osclen == (strlen(osc) + 1));
- lprof->lp_dt = kzalloc(osclen, GFP_NOFS);
+ lprof->lp_dt = kmemdup(osc, osclen, GFP_NOFS);
if (lprof->lp_dt == NULL) {
err = -ENOMEM;
goto free_lp_profile;
}
- memcpy(lprof->lp_dt, osc, osclen);
if (mdclen > 0) {
LASSERT(mdclen == (strlen(mdc) + 1));
- lprof->lp_md = kzalloc(mdclen, GFP_NOFS);
+ lprof->lp_md = kmemdup(mdc, mdclen, GFP_NOFS);
if (lprof->lp_md == NULL) {
err = -ENOMEM;
goto free_lp_dt;
}
- memcpy(lprof->lp_md, mdc, mdclen);
}
list_add(&lprof->lp_list, &lustre_profile_list);
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-31 5:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-31 5:39 [PATCH v2] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup Dighe, Niranjan (N.)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.