From: Lee Jones <lee.jones@linaro.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Andreas Ruprecht <andreas.ruprecht@fau.de>,
Paul Bolle <pebolle@tiscali.nl>,
hengelein Stefan <stefan.hengelein@fau.de>,
wim@iguana.be, david.paris@st.com, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: watchdog: st_wdt: select on undefined MFD_ST_LPC
Date: Mon, 1 Jun 2015 18:55:13 +0100 [thread overview]
Message-ID: <20150601175513.GG3329@x1> (raw)
In-Reply-To: <CAD3Xx4JLanN3Luo1ijtPAA5LKz8fiWU=zs2SuCGvGn6JTMka_Q@mail.gmail.com>
On Mon, 01 Jun 2015, Valentin Rothberg wrote:
> Hi Lee,
>
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
>
> +config ST_LPC_WATCHDOG
> ...
> + select MFD_ST_LPC
>
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig. Is it the correct option to be selected? I could not find a
> similar option in the source, nor get any hints from searching the
> lkml.
>
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.
You're right. This symbol is legacy. I will remove.
Thanks for reporting.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Andreas Ruprecht <andreas.ruprecht@fau.de>,
Paul Bolle <pebolle@tiscali.nl>,
hengelein Stefan <stefan.hengelein@fau.de>,
wim@iguana.be, david.paris@st.com, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: watchdog: st_wdt: select on undefined MFD_ST_LPC
Date: Mon, 1 Jun 2015 18:55:13 +0100 [thread overview]
Message-ID: <20150601175513.GG3329@x1> (raw)
In-Reply-To: <CAD3Xx4JLanN3Luo1ijtPAA5LKz8fiWU=zs2SuCGvGn6JTMka_Q@mail.gmail.com>
On Mon, 01 Jun 2015, Valentin Rothberg wrote:
> Hi Lee,
>
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
>
> +config ST_LPC_WATCHDOG
> ...
> + select MFD_ST_LPC
>
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig. Is it the correct option to be selected? I could not find a
> similar option in the source, nor get any hints from searching the
> lkml.
>
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.
You're right. This symbol is legacy. I will remove.
Thanks for reporting.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-06-01 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:09 watchdog: st_wdt: select on undefined MFD_ST_LPC Valentin Rothberg
2015-06-01 17:55 ` Lee Jones [this message]
2015-06-01 17:55 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601175513.GG3329@x1 \
--to=lee.jones@linaro.org \
--cc=andreas.ruprecht@fau.de \
--cc=david.paris@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.