From: Tony Lindgren <tony@atomide.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-omap@vger.kernel.org, linux@arm.linux.org.uk,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] mach-omap2:Remove unnessary return statement from the void function, omap2_show_dma_caps
Date: Mon, 1 Jun 2015 15:02:38 -0700 [thread overview]
Message-ID: <20150601220237.GI30984@atomide.com> (raw)
In-Reply-To: <1432825205-4663-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [150528 08:06]:
> This removes the no longer required return statement at the end
> of the void function, omap2_show_dma_cap due to no need for a
> return statement due to this function always running successfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-omap2/dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index e1a56d8..1ed4be1 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -117,7 +117,6 @@ static void omap2_show_dma_caps(void)
> u8 revision = dma_read(REVISION, 0) & 0xff;
> printk(KERN_INFO "OMAP DMA hardware revision %d.%d\n",
> revision >> 4, revision & 0xf);
> - return;
> }
>
> static unsigned configure_dma_errata(void)
Sorry for the delay, applying this into omap-for-v4.2/fixes as
it's not urgent.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] mach-omap2:Remove unnessary return statement from the void function, omap2_show_dma_caps
Date: Mon, 1 Jun 2015 15:02:38 -0700 [thread overview]
Message-ID: <20150601220237.GI30984@atomide.com> (raw)
In-Reply-To: <1432825205-4663-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> [150528 08:06]:
> This removes the no longer required return statement at the end
> of the void function, omap2_show_dma_cap due to no need for a
> return statement due to this function always running successfully.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-omap2/dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index e1a56d8..1ed4be1 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -117,7 +117,6 @@ static void omap2_show_dma_caps(void)
> u8 revision = dma_read(REVISION, 0) & 0xff;
> printk(KERN_INFO "OMAP DMA hardware revision %d.%d\n",
> revision >> 4, revision & 0xf);
> - return;
> }
>
> static unsigned configure_dma_errata(void)
Sorry for the delay, applying this into omap-for-v4.2/fixes as
it's not urgent.
Regards,
Tony
next prev parent reply other threads:[~2015-06-01 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 15:00 [PATCH RESEND] mach-omap2:Remove unnessary return statement from the void function, omap2_show_dma_caps Nicholas Krause
2015-05-28 15:00 ` Nicholas Krause
2015-06-01 22:02 ` Tony Lindgren [this message]
2015-06-01 22:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601220237.GI30984@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.