From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Assegai <isaac.a.travers@gmail.com>
Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files.
Date: Tue, 02 Jun 2015 06:48:15 +0000 [thread overview]
Message-ID: <20150602064806.GF6382@sudip-PC> (raw)
In-Reply-To: <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com>
On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the following checkpatch
> errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 46 +++++++++++++++++------------------
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> drivers/staging/sm750fb/sm750_help.h | 2 +-
> 3 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 4e252fb..a054747 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -101,29 +101,29 @@ static int programModeRegisters(mode_parameter_t * pModeParam, pll_value_t * pll
> | FIELD_VALUE(0, CRT_VERTICAL_SYNC, START, pModeParam->vertical_sync_start - 1));
>
>
> - ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL,VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> + ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL, VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> FIELD_VALUE(0, CRT_DISPLAY_CTRL, HSYNC_PHASE, pModeParam->horizontal_sync_polarity)|
> - FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING,ENABLE)|
> - FIELD_SET(0,CRT_DISPLAY_CTRL,PLANE,ENABLE);
> + FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING, ENABLE)|
> + FIELD_SET(0, CRT_DISPLAY_CTRL, PLANE, ENABLE);
I am getting confused now.
This part you have modified in patch 10/12 and i just replied that
you have missed two modifications.
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Assegai <isaac.a.travers@gmail.com>
Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files.
Date: Tue, 2 Jun 2015 12:18:06 +0530 [thread overview]
Message-ID: <20150602064806.GF6382@sudip-PC> (raw)
In-Reply-To: <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com>
On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the following checkpatch
> errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 46 +++++++++++++++++------------------
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> drivers/staging/sm750fb/sm750_help.h | 2 +-
> 3 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 4e252fb..a054747 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -101,29 +101,29 @@ static int programModeRegisters(mode_parameter_t * pModeParam, pll_value_t * pll
> | FIELD_VALUE(0, CRT_VERTICAL_SYNC, START, pModeParam->vertical_sync_start - 1));
>
>
> - ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL,VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> + ulTmpValue = FIELD_VALUE(0, CRT_DISPLAY_CTRL, VSYNC_PHASE, pModeParam->vertical_sync_polarity)|
> FIELD_VALUE(0, CRT_DISPLAY_CTRL, HSYNC_PHASE, pModeParam->horizontal_sync_polarity)|
> - FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING,ENABLE)|
> - FIELD_SET(0,CRT_DISPLAY_CTRL,PLANE,ENABLE);
> + FIELD_SET(0, CRT_DISPLAY_CTRL, TIMING, ENABLE)|
> + FIELD_SET(0, CRT_DISPLAY_CTRL, PLANE, ENABLE);
I am getting confused now.
This part you have modified in patch 10/12 and i just replied that
you have missed two modifications.
regards
sudip
next prev parent reply other threads:[~2015-06-02 6:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1433134873-9869-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1433134873-9869-3-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:15 ` [PATCH 02/12] Staging: sm750fb: sm750_help.h: Insert spaces after commas Sudip Mukherjee
2015-06-02 6:27 ` Sudip Mukherjee
[not found] ` <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:25 ` [PATCH 03/12] Staging: sm750fb: sm750.h: " Sudip Mukherjee
2015-06-02 6:37 ` Sudip Mukherjee
[not found] ` <1433134873-9869-11-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:41 ` [PATCH 10/12] Staging: sm750fb: Insert spaces after commas in two files Sudip Mukherjee
2015-06-02 6:53 ` Sudip Mukherjee
[not found] ` <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:48 ` Sudip Mukherjee [this message]
2015-06-02 6:48 ` [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files Sudip Mukherjee
2015-06-02 7:55 ` Isaac Assegai
2015-06-02 7:55 ` Isaac Assegai
2015-06-02 8:25 ` Sudip Mukherjee
2015-06-02 8:37 ` Sudip Mukherjee
2015-06-02 8:30 ` Isaac Assegai
2015-06-02 8:30 ` Isaac Assegai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602064806.GF6382@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isaac.a.travers@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.