From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [media] m88ds3103: a couple missing error codes
Date: Tue, 02 Jun 2015 10:20:00 +0000 [thread overview]
Message-ID: <20150602102000.GD11247@mwanda> (raw)
We need to set some error codes here.
Fixes: f01919e8f54f ('[media] m88ds3103: add I2C client binding')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index 01b9ded..7b21f1a 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -1563,6 +1563,7 @@ static int m88ds3103_probe(struct i2c_client *client,
u8tmp = 0x10;
break;
default:
+ ret = -EINVAL;
goto err_kfree;
}
@@ -1590,8 +1591,10 @@ static int m88ds3103_probe(struct i2c_client *client,
dev->i2c_adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
dev, 0, 0, 0, m88ds3103_select,
m88ds3103_deselect);
- if (dev->i2c_adapter = NULL)
+ if (dev->i2c_adapter = NULL) {
+ ret = -ENOMEM;
goto err_kfree;
+ }
/* create dvb_frontend */
memcpy(&dev->fe.ops, &m88ds3103_ops, sizeof(struct dvb_frontend_ops));
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [media] m88ds3103: a couple missing error codes
Date: Tue, 2 Jun 2015 13:20:00 +0300 [thread overview]
Message-ID: <20150602102000.GD11247@mwanda> (raw)
We need to set some error codes here.
Fixes: f01919e8f54f ('[media] m88ds3103: add I2C client binding')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index 01b9ded..7b21f1a 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -1563,6 +1563,7 @@ static int m88ds3103_probe(struct i2c_client *client,
u8tmp = 0x10;
break;
default:
+ ret = -EINVAL;
goto err_kfree;
}
@@ -1590,8 +1591,10 @@ static int m88ds3103_probe(struct i2c_client *client,
dev->i2c_adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
dev, 0, 0, 0, m88ds3103_select,
m88ds3103_deselect);
- if (dev->i2c_adapter == NULL)
+ if (dev->i2c_adapter == NULL) {
+ ret = -ENOMEM;
goto err_kfree;
+ }
/* create dvb_frontend */
memcpy(&dev->fe.ops, &m88ds3103_ops, sizeof(struct dvb_frontend_ops));
next reply other threads:[~2015-06-02 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:20 Dan Carpenter [this message]
2015-06-02 10:20 ` [patch] [media] m88ds3103: a couple missing error codes Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602102000.GD11247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.