From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status
Date: Tue, 2 Jun 2015 14:51:00 +0300 [thread overview]
Message-ID: <20150602115100.GX5176@intel.com> (raw)
In-Reply-To: <1433243867-20976-1-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Tue, Jun 02, 2015 at 02:17:47PM +0300, Ander Conselvan de Oliveira wrote:
> Add all missing platforms handled by intel_set_memory_cxsr() to the
> i915_sr_status debugfs entry.
>
> v2: Add G4X too. (Ville)
> Clarify the change also affects CHV. (Ander)
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=89792
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
It's a good enough white lie for my taste.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I would also accept removing the entire file, but we can keep it if
people find some use for it.
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fece922..564a6ba 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1725,12 +1725,15 @@ static int i915_sr_status(struct seq_file *m, void *unused)
>
> if (HAS_PCH_SPLIT(dev))
> sr_enabled = I915_READ(WM1_LP_ILK) & WM1_LP_SR_EN;
> - else if (IS_CRESTLINE(dev) || IS_I945G(dev) || IS_I945GM(dev))
> + else if (IS_CRESTLINE(dev) || IS_G4X(dev) ||
> + IS_I945G(dev) || IS_I945GM(dev))
> sr_enabled = I915_READ(FW_BLC_SELF) & FW_BLC_SELF_EN;
> else if (IS_I915GM(dev))
> sr_enabled = I915_READ(INSTPM) & INSTPM_SELF_EN;
> else if (IS_PINEVIEW(dev))
> sr_enabled = I915_READ(DSPFW3) & PINEVIEW_SELF_REFRESH_EN;
> + else if (IS_VALLEYVIEW(dev))
> + sr_enabled = I915_READ(FW_BLC_SELF_VLV) & FW_CSPWRDWNEN;
>
> intel_runtime_pm_put(dev_priv);
>
> --
> 2.1.0
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-02 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 18:18 [PATCH] drm/i915: list self-refresh as enabled on newer platforms Jesse Barnes
2015-04-02 18:42 ` Ville Syrjälä
2015-04-02 18:48 ` Jesse Barnes
2015-05-27 7:05 ` [PATCH] drm/i915: Include VLV in self refresh status Ander Conselvan de Oliveira
2015-06-02 11:17 ` [PATCH] drm/i915: Include G4X/VLV/CHV " Ander Conselvan de Oliveira
2015-06-02 11:51 ` Ville Syrjälä [this message]
2015-06-02 11:58 ` Jani Nikula
2015-06-04 8:23 ` Jani Nikula
2015-06-02 17:46 ` shuang.he
2015-04-03 5:21 ` [PATCH] drm/i915: list self-refresh as enabled on newer platforms shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602115100.GX5176@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.