From: Joerg Roedel <joro@8bytes.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Li@mwanda, Zhen-Hua <zhen-hual@hp.com>,
iommu@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()
Date: Tue, 02 Jun 2015 13:45:18 +0000 [thread overview]
Message-ID: <20150602134505.GA20381@8bytes.org> (raw)
In-Reply-To: <20150602100958.GC11247@mwanda>
On Tue, Jun 02, 2015 at 01:09:58PM +0300, Dan Carpenter wrote:
> Smatch found some error paths that don't unlock. Also we can return
> -ENOMEM instead of -1 if we don't have an old root entry.
>
> Fixes: 5908f10af4b9 ('iommu/vt-d: datatypes and functions used for kdump')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
> Releasing the lock is good, but we might need to do other error handling
> as well. Presumably this function always succeeds anyway? It seems
> like it might be essential for booting.
What do you mean by 'other error handling'? In error case a negative
value is returned and the caller checks that.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Li@mwanda, Zhen-Hua <zhen-hual@hp.com>,
iommu@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()
Date: Tue, 2 Jun 2015 15:45:18 +0200 [thread overview]
Message-ID: <20150602134505.GA20381@8bytes.org> (raw)
In-Reply-To: <20150602100958.GC11247@mwanda>
On Tue, Jun 02, 2015 at 01:09:58PM +0300, Dan Carpenter wrote:
> Smatch found some error paths that don't unlock. Also we can return
> -ENOMEM instead of -1 if we don't have an old root entry.
>
> Fixes: 5908f10af4b9 ('iommu/vt-d: datatypes and functions used for kdump')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
> Releasing the lock is good, but we might need to do other error handling
> as well. Presumably this function always succeeds anyway? It seems
> like it might be essential for booting.
What do you mean by 'other error handling'? In error case a negative
value is returned and the caller checks that.
Joerg
next prev parent reply other threads:[~2015-06-02 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:09 [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables() Dan Carpenter
2015-06-02 10:09 ` Dan Carpenter
2015-06-02 13:45 ` Joerg Roedel [this message]
2015-06-02 13:45 ` Joerg Roedel
2015-06-02 14:06 ` Dan Carpenter
2015-06-02 14:06 ` Dan Carpenter
2015-06-03 5:25 ` Li, ZhenHua
2015-06-03 5:25 ` Li, ZhenHua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602134505.GA20381@8bytes.org \
--to=joro@8bytes.org \
--cc=Li@mwanda \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=zhen-hual@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.