From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@codeaurora.org>,
linux-pm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
David Collins <collinsd@codeaurora.org>
Subject: Re: [PATCH 3/6] PM / OPP: Support adjusting OPP voltages at runtime
Date: Tue, 2 Jun 2015 12:54:21 -0700 [thread overview]
Message-ID: <20150602195421.GA11764@codeaurora.org> (raw)
In-Reply-To: <20150602045026.GC10443@linux>
On 06/02, Viresh Kumar wrote:
> On 01-06-15, 18:47, Stephen Boyd wrote:
> > +int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq,
> > + unsigned long u_volt);
>
> > +static inline int dev_pm_opp_adjust_voltage(struct device *dev,
> > + unsigned long freq, unsigned long u_volt)
>
> The 'u' of 'unsigned' isn't aligned to the opening curly brace. Try
> running with checkpatch --strict and you will see some warnings.
>
> Otherwise,
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Will do. Thanks.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] PM / OPP: Support adjusting OPP voltages at runtime
Date: Tue, 2 Jun 2015 12:54:21 -0700 [thread overview]
Message-ID: <20150602195421.GA11764@codeaurora.org> (raw)
In-Reply-To: <20150602045026.GC10443@linux>
On 06/02, Viresh Kumar wrote:
> On 01-06-15, 18:47, Stephen Boyd wrote:
> > +int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq,
> > + unsigned long u_volt);
>
> > +static inline int dev_pm_opp_adjust_voltage(struct device *dev,
> > + unsigned long freq, unsigned long u_volt)
>
> The 'u' of 'unsigned' isn't aligned to the opening curly brace. Try
> running with checkpatch --strict and you will see some warnings.
>
> Otherwise,
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Will do. Thanks.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-06-02 19:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 1:47 [PATCH 0/6] Support CPR on MSM8916 Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-02 1:47 ` [PATCH 1/6] regulator: core: Don't spew backtraces on duplicate sysfs Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-03 12:20 ` Mark Brown
2015-06-03 12:20 ` Mark Brown
2015-06-02 1:47 ` [PATCH 2/6] regulator: core: Print at debug level on debugfs creation failure Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-03 18:39 ` Mark Brown
2015-06-03 18:39 ` Mark Brown
2015-06-02 1:47 ` [PATCH 3/6] PM / OPP: Support adjusting OPP voltages at runtime Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-02 4:50 ` Viresh Kumar
2015-06-02 4:50 ` Viresh Kumar
2015-06-02 19:54 ` Stephen Boyd [this message]
2015-06-02 19:54 ` Stephen Boyd
2015-06-02 1:47 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free Stephen Boyd
2015-06-02 1:47 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage, freq} RCU-free Stephen Boyd
2015-06-02 3:30 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free Krzysztof Kozlowski
2015-06-02 3:30 ` Krzysztof Kozlowski
2015-06-03 22:43 ` Stephen Boyd
2015-06-03 22:43 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage, freq} RCU-free Stephen Boyd
2015-06-02 1:47 ` [PATCH 5/6] cpufreq-dt: Handle OPP voltage adjust events Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-02 1:47 ` [PATCH 6/6] power: avs: Add support for CPR (Core Power Reduction) Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd
2015-06-02 10:53 ` [PATCH 0/6] Support CPR on MSM8916 Mark Brown
2015-06-02 10:53 ` Mark Brown
2015-06-02 17:56 ` Stephen Boyd
2015-06-02 17:56 ` Stephen Boyd
2015-06-02 18:20 ` Mark Brown
2015-06-02 18:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602195421.GA11764@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.