From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-iio@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] change "client->irq >= 0" to "client->irq > 0"
Date: Wed, 3 Jun 2015 13:02:41 +0200 [thread overview]
Message-ID: <20150603110241.GK1715@piout.net> (raw)
In-Reply-To: <1433280853-3988-1-git-send-email-octavian.purdila@intel.com>
On 03/06/2015 at 00:34:11 +0300, Octavian Purdila wrote :
> This fixes an issue introduces by commit dab472eb931b ("i2c / ACPI:
> Use 0 to indicate that device does not have interrupt assigned") where
> drivers will try to request IRQ 0 when no GpioInt is defined in ACPI.
>
> The same issue occurs when the device is instantiated via device tree
> with no IRQ, or from the i2c sysfs interface, even before the patch
> above.
>
> Linus, since the commit above was already merged in the GPIO tree,
> should these fixes be merged also via the GPIO tree (with ACKs from
> the others subsystem maintainers)?
>
Side question, has it been considered that IRQ 0 is valid on some
platform and that means i2c devices will not be able to be wired to that
IRQ anymore? Though, I don't think there are any existing design that
does so.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-iio@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH 0/2] change "client->irq >= 0" to "client->irq > 0"
Date: Wed, 3 Jun 2015 13:02:41 +0200 [thread overview]
Message-ID: <20150603110241.GK1715@piout.net> (raw)
In-Reply-To: <1433280853-3988-1-git-send-email-octavian.purdila@intel.com>
On 03/06/2015 at 00:34:11 +0300, Octavian Purdila wrote :
> This fixes an issue introduces by commit dab472eb931b ("i2c / ACPI:
> Use 0 to indicate that device does not have interrupt assigned") where
> drivers will try to request IRQ 0 when no GpioInt is defined in ACPI.
>
> The same issue occurs when the device is instantiated via device tree
> with no IRQ, or from the i2c sysfs interface, even before the patch
> above.
>
> Linus, since the commit above was already merged in the GPIO tree,
> should these fixes be merged also via the GPIO tree (with ACKs from
> the others subsystem maintainers)?
>
Side question, has it been considered that IRQ 0 is valid on some
platform and that means i2c devices will not be able to be wired to that
IRQ anymore? Though, I don't think there are any existing design that
does so.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-06-03 11:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 21:34 [PATCH 0/2] change "client->irq >= 0" to "client->irq > 0" Octavian Purdila
2015-06-02 21:34 ` [rtc-linux] " Octavian Purdila
2015-06-02 21:34 ` [PATCH 1/2] iio: " Octavian Purdila
2015-06-02 21:34 ` [rtc-linux] " Octavian Purdila
2015-06-03 10:27 ` Mika Westerberg
2015-06-03 10:27 ` [rtc-linux] " Mika Westerberg
2015-06-02 21:34 ` [PATCH 2/2] rtc: " Octavian Purdila
2015-06-02 21:34 ` [rtc-linux] " Octavian Purdila
2015-06-02 22:54 ` Alexandre Belloni
2015-06-02 22:54 ` [rtc-linux] " Alexandre Belloni
2015-06-03 10:32 ` Mika Westerberg
2015-06-03 10:32 ` [rtc-linux] " Mika Westerberg
2015-06-03 11:02 ` Alexandre Belloni [this message]
2015-06-03 11:02 ` [rtc-linux] Re: [PATCH 0/2] " Alexandre Belloni
2015-06-03 17:05 ` Octavian Purdila
2015-06-03 17:05 ` [rtc-linux] " Octavian Purdila
2015-06-03 19:20 ` Alexandre Belloni
2015-06-03 19:20 ` [rtc-linux] " Alexandre Belloni
2015-06-03 17:13 ` Lars-Peter Clausen
2015-06-03 17:13 ` [rtc-linux] " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603110241.GK1715@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=rtc-linux@googlegroups.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.