From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] arch: tidy up mmu config
Date: Wed, 3 Jun 2015 11:12:54 -0300 [thread overview]
Message-ID: <20150603141254.GA18352@fox> (raw)
In-Reply-To: <556CBBFC.4080002@mind.be>
Hi Arnout!
On Mon, Jun 01, 2015 at 10:09:32PM +0200, Arnout Vandecappelle wrote:
> On 05/21/15 18:54, Guido Mart?nez wrote:
> > Instead of blacklisting which architectures support MMUs (mandatorily
> > or optionally), introduce two Kconfig options that are selected by each
> > architecture in each case.
> >
> > This simplifies the logic in BR2_USE_MMU.
> >
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Two small improvements, but even without them this patch is OK for me.
>
> - In arch/Config.in, the ARM section and the Blackfin section look the same to
> the casual onlooker, but for ARM the MMU options depend on the subarchitecture,
> while for Blackfin it's always NOMMU. So I'd make this explicit by adding a
> comment for ARM:
>
> config BR2_arm
> bool "ARM (little endian)"
> # MMU support is set by subarchitectur in Config.in.arm
>
> Same for ELF in the second patch.
>
> - Like you did for ARM, I think you should move the MMU selection to the
> subarches for xtensa as well. Since in fact, the fsf variant is always MMU.
>
>
> So if you repost this patch and make the above changes, you can add my Acked-by.
Just resent the patches after applying these comments and the binfmt one
too.
Thanks a lot for reviewing!
--
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-06-03 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 16:54 [Buildroot] [PATCH 1/2] arch: tidy up mmu config Guido Martínez
2015-05-21 16:54 ` [Buildroot] [PATCH 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-01 20:32 ` Arnout Vandecappelle
2015-06-01 16:59 ` [Buildroot] [PATCH 1/2] arch: tidy up mmu config Ezequiel Garcia
2015-06-01 20:09 ` Arnout Vandecappelle
2015-06-03 14:12 ` Guido Martínez [this message]
2015-06-03 14:12 ` [Buildroot] [PATCH v2 " Guido Martínez
2015-06-03 14:12 ` [Buildroot] [PATCH v2 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-03 20:48 ` Arnout Vandecappelle
2015-06-03 21:27 ` Guido Martínez
2015-06-03 22:29 ` Arnout Vandecappelle
2015-06-03 22:34 ` Guido Martínez
2015-06-03 22:34 ` [Buildroot] [PATCH v3 1/2] arch: tidy up mmu config Guido Martínez
2015-06-03 22:34 ` [Buildroot] [PATCH v3 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-09 20:52 ` [Buildroot] [PATCH v3 1/2] arch: tidy up mmu config Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603141254.GA18352@fox \
--to=guido@vanguardiasur.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.