From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] arch: tidy up binary formats config
Date: Wed, 3 Jun 2015 18:27:53 -0300 [thread overview]
Message-ID: <20150603212753.GA2858@fox> (raw)
In-Reply-To: <556F682B.1030306@mind.be>
On Wed, Jun 03, 2015 at 10:48:43PM +0200, Arnout Vandecappelle wrote:
> On 06/03/15 16:12, Guido Mart?nez wrote:
> > @@ -272,13 +276,13 @@ config BR2_BINFMT_SUPPORTS_SHARED
> > # Set up target binary format
> > choice
> > prompt "Target Binary Format"
> > - default BR2_BINFMT_ELF if !(BR2_bfin || BR2_m68k)
> > - default BR2_BINFMT_FDPIC if BR2_bfin
> > - default BR2_BINFMT_FLAT if BR2_m68k
> > + default BR2_BINFMT_ELF if BR2_USE_MMU
> > + default BR2_BINFMT_FDPIC if BR2_ARCH_HAS_FDPIC_SUPPORT
> > + default BR2_BINFMT_FLAT if !BR2_USE_MMU
>
> I think this should either be without condition at all, or with a condition
> that matches the previous ones, i.e. if !BR2_USE_MMU && !BR2_ARCH_HAS_FDPIC_SUPPORT.
Ugh, right, either fully use the short circuiting or not at all. I'd say
we use no conditions on FLAT.
> Also we normally don't do any vertical alignment at all, so just put a single
> space instead of tabs.
OK, agreed.
Would it be better for me to resend or is this simple enough to be fixed
up when commiting?
Thanks!
--
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-06-03 21:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 16:54 [Buildroot] [PATCH 1/2] arch: tidy up mmu config Guido Martínez
2015-05-21 16:54 ` [Buildroot] [PATCH 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-01 20:32 ` Arnout Vandecappelle
2015-06-01 16:59 ` [Buildroot] [PATCH 1/2] arch: tidy up mmu config Ezequiel Garcia
2015-06-01 20:09 ` Arnout Vandecappelle
2015-06-03 14:12 ` Guido Martínez
2015-06-03 14:12 ` [Buildroot] [PATCH v2 " Guido Martínez
2015-06-03 14:12 ` [Buildroot] [PATCH v2 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-03 20:48 ` Arnout Vandecappelle
2015-06-03 21:27 ` Guido Martínez [this message]
2015-06-03 22:29 ` Arnout Vandecappelle
2015-06-03 22:34 ` Guido Martínez
2015-06-03 22:34 ` [Buildroot] [PATCH v3 1/2] arch: tidy up mmu config Guido Martínez
2015-06-03 22:34 ` [Buildroot] [PATCH v3 2/2] arch: tidy up binary formats config Guido Martínez
2015-06-09 20:52 ` [Buildroot] [PATCH v3 1/2] arch: tidy up mmu config Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603212753.GA2858@fox \
--to=guido@vanguardiasur.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.