From: Christoffer Dall <christoffer.dall@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com,
pbonzini@redhat.com, zhichao.huang@linaro.org,
jan.kiszka@siemens.com, dahi@linux.vnet.ibm.com,
r65777@freescale.com, bp@suse.de, Gleb Natapov <gleb@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug
Date: Thu, 4 Jun 2015 13:07:40 +0200 [thread overview]
Message-ID: <20150604110740.GH7657@cbox> (raw)
In-Reply-To: <1432891828-4816-6-git-send-email-alex.bennee@linaro.org>
On Fri, May 29, 2015 at 10:30:21AM +0100, Alex Bennée wrote:
> This is a precursor for later patches which will need to do more to
> setup debug state before entering the hyp.S switch code. The existing
> functionality for setting mdcr_el2 has been moved out of hyp.S and now
> uses the value kept in vcpu->arch.mdcr_el2.
>
> As the assembler used to previously mask and preserve MDCR_EL2.HPMN I've
> had to add a mechanism to save the value of mdcr_el2 as a per-cpu
> variable during the initialisation code. The kernel never sets this
> number so we are assuming the bootcode has set up the correct value
> here.
>
> This also moves the conditional setting of the TDA bit from the hyp code
> into the C code which is currently used for the lazy debug register
> context switch code.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug
Date: Thu, 4 Jun 2015 13:07:40 +0200 [thread overview]
Message-ID: <20150604110740.GH7657@cbox> (raw)
In-Reply-To: <1432891828-4816-6-git-send-email-alex.bennee@linaro.org>
On Fri, May 29, 2015 at 10:30:21AM +0100, Alex Benn?e wrote:
> This is a precursor for later patches which will need to do more to
> setup debug state before entering the hyp.S switch code. The existing
> functionality for setting mdcr_el2 has been moved out of hyp.S and now
> uses the value kept in vcpu->arch.mdcr_el2.
>
> As the assembler used to previously mask and preserve MDCR_EL2.HPMN I've
> had to add a mechanism to save the value of mdcr_el2 as a per-cpu
> variable during the initialisation code. The kernel never sets this
> number so we are assuming the bootcode has set up the correct value
> here.
>
> This also moves the conditional setting of the TDA bit from the hyp code
> into the C code which is currently used for the lazy debug register
> context switch code.
>
> Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2015-06-04 11:07 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 9:30 [PATCH v5 00/12] KVM Guest Debug support for arm64 Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 01/12] KVM: add comments for kvm_debug_exit_arch struct Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 02/12] KVM: arm64: fix misleading comments in save/restore Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 03/12] KVM: arm64: guest debug, define API headers Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 13:49 ` Alex Bennée
2015-06-04 13:49 ` Alex Bennée
2015-06-04 13:49 ` Alex Bennée
2015-06-04 14:40 ` Andrew Jones
2015-06-04 14:40 ` Andrew Jones
2015-05-29 9:30 ` [PATCH v5 04/12] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 05/12] KVM: arm: introduce kvm_arm_init/setup/clear_debug Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-04 11:07 ` Christoffer Dall [this message]
2015-06-04 11:07 ` Christoffer Dall
2015-05-29 9:30 ` [PATCH v5 06/12] KVM: arm64: guest debug, add SW break point support Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 07/12] KVM: arm64: guest debug, add support for single-step Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 11:07 ` Christoffer Dall
2015-06-04 13:46 ` Alex Bennée
2015-06-04 13:46 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 08/12] KVM: arm64: re-factor hyp.S debug register code Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-04 10:23 ` Christoffer Dall
2015-06-04 10:23 ` Christoffer Dall
2015-06-04 10:34 ` Alex Bennée
2015-06-04 10:34 ` Alex Bennée
2015-06-04 10:34 ` Alex Bennée
2015-06-04 11:12 ` Christoffer Dall
2015-06-04 11:12 ` Christoffer Dall
2015-05-29 9:30 ` [PATCH v5 09/12] KVM: arm64: introduce vcpu->arch.debug_ptr Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-04 10:56 ` Christoffer Dall
2015-06-04 10:56 ` Christoffer Dall
2015-06-04 10:56 ` Christoffer Dall
2015-05-29 9:30 ` [PATCH v5 10/12] KVM: arm64: guest debug, HW assisted debug support Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-06-01 9:15 ` Will Deacon
2015-06-01 9:15 ` Will Deacon
2015-06-01 9:15 ` Will Deacon
2015-06-01 12:41 ` Alex Bennée
2015-06-01 12:41 ` Alex Bennée
2015-06-01 12:41 ` Alex Bennée
[not found] ` <1432891828-4816-11-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-04 11:06 ` Christoffer Dall
2015-06-04 11:06 ` Christoffer Dall
2015-06-04 11:06 ` Christoffer Dall
2015-05-29 9:30 ` [PATCH v5 11/12] KVM: arm64: enable KVM_CAP_SET_GUEST_DEBUG Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` [PATCH v5 12/12] KVM: arm64: add trace points for guest_debug debug Alex Bennée
2015-05-29 9:30 ` Alex Bennée
2015-05-29 9:30 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604110740.GH7657@cbox \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=andre.przywara@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=drjones@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=r65777@freescale.com \
--cc=richard@nod.at \
--cc=will.deacon@arm.com \
--cc=zhichao.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.