From: Al Viro <viro@ZenIV.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
linux-nfs@vger.kernel.org,
Vasily Isaenko <vasily.isaenko@oracle.com>,
"SHUANG.QIU" <shuang.qiu@oracle.com>
Subject: Re: nfsd: EACCES vs EPERM on utime()/utimes() calls
Date: Fri, 5 Jun 2015 01:50:43 +0100 [thread overview]
Message-ID: <20150605005043.GR7232@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150604202725.GE5209@fieldses.org>
On Thu, Jun 04, 2015 at 04:27:25PM -0400, J. Bruce Fields wrote:
> I wonder if we could instead skip the fh_verify's inode_permission call
> entirely? Most callers of fh_verify don't need the inode_permission
> call at all as far as I can tell, because the following vfs operation
> does permission checking already.
In case of notify_change() we only pass a dentry, so anything mount-dependent
must be done in callers... Actually, I wonder how does tomoyo and its ilk
interact with nfsd?
next prev parent reply other threads:[~2015-06-05 0:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:01 nfsd: EACCES vs EPERM on utime()/utimes() calls Stanislav Kholmanskikh
2015-06-01 21:23 ` J. Bruce Fields
2015-06-02 16:09 ` Stanislav Kholmanskikh
2015-06-04 12:43 ` Kinglong Mee
2015-06-04 20:27 ` J. Bruce Fields
2015-06-05 0:50 ` Al Viro [this message]
2015-06-07 8:25 ` Kinglong Mee
2015-06-05 15:30 ` Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605005043.GR7232@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=shuang.qiu@oracle.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.