From: Dan Carpenter <dan.carpenter@oracle.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH v3 1/8] staging:lustre: assume a kernel build
Date: Fri, 5 Jun 2015 12:02:00 +0300 [thread overview]
Message-ID: <20150605090200.GL28762@mwanda> (raw)
In-Reply-To: <1433364207-14307-2-git-send-email-jsimmons@infradead.org>
This whole patchset looks find to me.
Some tips for the future.
On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@intel.com>
>
> In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that
> __KERNEL__ is defined). Remove some common code only needed for user
> space LNet.
>
> - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES,
> - sizeof(lnet_me_t));
> + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0);
When I'm reviewing "delete code" patches, I pretty much focus on the
plus lines like this one. Obviously, I can figure out why we changed
the parameters to zero but it saves me time if it's spelled out in the
changelog.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
"John L. Hammond" <john.hammond@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH v3 1/8] staging:lustre: assume a kernel build
Date: Fri, 5 Jun 2015 12:02:00 +0300 [thread overview]
Message-ID: <20150605090200.GL28762@mwanda> (raw)
In-Reply-To: <1433364207-14307-2-git-send-email-jsimmons@infradead.org>
This whole patchset looks find to me.
Some tips for the future.
On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@intel.com>
>
> In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that
> __KERNEL__ is defined). Remove some common code only needed for user
> space LNet.
>
> - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES,
> - sizeof(lnet_me_t));
> + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0);
When I'm reviewing "delete code" patches, I pretty much focus on the
plus lines like this one. Obviously, I can figure out why we changed
the parameters to zero but it saves me time if it's spelled out in the
changelog.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-05 9:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 20:43 [lustre-devel] [PATCH v3 0/8] staging:lustre: remove kernel defines in userland headers James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 1/8] staging:lustre: assume a kernel build James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-05 9:02 ` Dan Carpenter [this message]
2015-06-05 9:02 ` Dan Carpenter
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 2/8] staging:lustre: fixup LNet resource container api James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 3/8] staging:lustre: delete no longer used LNet headers James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-08 19:38 ` [lustre-devel] " Greg Kroah-Hartman
2015-06-08 19:38 ` Greg Kroah-Hartman
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 4/8] staging:lustre: move LNet NID macros to LNet layer James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-05 9:02 ` [lustre-devel] " Dan Carpenter
2015-06-05 9:02 ` Dan Carpenter
2015-06-09 0:33 ` [lustre-devel] " Dilger, Andreas
2015-06-09 0:33 ` Dilger, Andreas
2015-06-09 14:59 ` Simmons, James A.
2015-06-09 14:59 ` Simmons, James A.
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 6/8] staging:lustre: fix camel case for LNetInit and LNetFini James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 7/8] staging:lustre: style cleanups for LNet headers James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-05 9:04 ` [lustre-devel] " Dan Carpenter
2015-06-05 9:04 ` Dan Carpenter
2015-06-09 15:01 ` [lustre-devel] " Simmons, James A.
2015-06-09 15:01 ` Simmons, James A.
2015-06-03 20:43 ` [lustre-devel] [PATCH v3 8/8] staging:lustre: Update license and copyright for the LNET headers James Simmons
2015-06-03 20:43 ` James Simmons
2015-06-04 6:19 ` [lustre-devel] " Sudip Mukherjee
2015-06-04 6:19 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605090200.GL28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.