Re: [PATCH] drm/panel: Add display timing for Okaya RS800480T-7X0GP

From: Thierry Reding <thierry.reding@gmail.com>
To: Gary Bisson <gary.bisson@boundarydevices.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: Add display timing for Okaya RS800480T-7X0GP
Date: Fri, 5 Jun 2015 14:28:10 +0200	[thread overview]
Message-ID: <20150605122809.GB759@ulmo.nvidia.com> (raw)
In-Reply-To: <1432827466-8104-1-git-send-email-gary.bisson@boundarydevices.com>

[-- Attachment #1.1: Type: text/plain, Size: 2907 bytes --]

On Thu, May 28, 2015 at 05:37:46PM +0200, Gary Bisson wrote:
> Add support for the Okaya RS800480T-7X0GP to the DRM simple panel
> driver.
> 
> The RS800480T-7X0GP is a WVGA (800x480) panel with an 18-bit parallel
> LCD interface. It supports pixel clocks in the range of 30-40 MHz.
> 
> This panel details can be found at:
> http://boundarydevices.com/product/7-800x480-display/
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> Hi all,
> 
> This patch is the follow-up of a request from Philipp to add the Okaya display
> to the simple panel driver.
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/346657.html
> 
> Regards,
> Gary
> ---
>  .../bindings/panel/okaya,rs800480t_7x0gp.txt       |  7 ++++++
>  .../devicetree/bindings/vendor-prefixes.txt        |  1 +
>  drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++++++++
>  3 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt
> 
> diff --git a/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt
> new file mode 100644
> index 0000000..f7c729d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/okaya,rs800480t_7x0gp.txt
> @@ -0,0 +1,7 @@
> +OKAYA Electric America, Inc. RS800480T-7X0GP 7" WVGA LCD panel
> +
> +Required properties:
> +- compatible: should be "okaya,rs800480t_7x0gp"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 4f35a00..06ce91c 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -145,6 +145,7 @@ nintendo	Nintendo
>  nokia	Nokia
>  nvidia	NVIDIA
>  nxp	NXP Semiconductors
> +okaya	OKAYA Electric America, Inc.
>  onnn	ON Semiconductor Corp.
>  opencores	OpenCores.org
>  ortustech	Ortus Technology Co., Ltd.

Can you split this change into a separate patch? It needs an Acked-by
from one of the device tree binding maintainers, so make sure to Cc them
when you repost. scripts/get_maintainer.pl will list them for you.

> +static const struct display_timing okaya_rs800480t_7x0gp_timing = {
> +	.pixelclock = { 30000000, 30000000, 40000000 },
> +	.hactive = { 800, 800, 800 },
> +	.hfront_porch = { 40, 40, 40 },
> +	.hback_porch = { 40, 40, 40 },
> +	.hsync_len = { 1, 48, 48 },
> +	.vactive = { 480, 480, 480 },
> +	.vfront_porch = { 13, 13, 13 },
> +	.vback_porch = { 29, 29, 29 },
> +	.vsync_len = { 3, 3, 3 },

It strikes me as odd that the porches and VSYNC width should be fixed
for the panel. Is this really the case?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel