* [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks
@ 2015-06-06 6:22 kdasaparna
2015-06-06 8:47 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: kdasaparna @ 2015-06-06 6:22 UTC (permalink / raw)
To: gregkh; +Cc: markh, lidza.louina, linux-kernel, devel, driverdev-devel
Removed the braces of if else statements which contain only one
statement
Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
b/drivers/staging/dgnc/dgnc_tty.c
index f81a375..6cd0b6a 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct
channel_t *ch)
* 3) NONE - Do nothing. Since we didn't do anything to turn
* off the
* other side, we don't need to do anything now.
*/
- if (qleft > (RQUEUESIZE / 2)) {
+ if (qleft > (RQUEUESIZE / 2))
/* HWFLOW */
if
(ch->ch_digi.digi_flags
& RTSPACE ||
ch->ch_c_cflag
& CRTSCTS) {
if
(ch->ch_flags
&
CH_RECEIVER_OFF)
{
@@
-921,10
+921,10
@@
void
dgnc_check_queue_flow_control(struct
channel_t
*ch)
ch->ch_bd->bd_ops->send_start_character(ch);
}
/* No
* FLOW
* */
- else
{
+
else
/* Nothing
* needed.
* */
- }
- }
+
+
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks 2015-06-06 6:22 [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks kdasaparna @ 2015-06-06 8:47 ` Dan Carpenter 0 siblings, 0 replies; 3+ messages in thread From: Dan Carpenter @ 2015-06-06 8:47 UTC (permalink / raw) To: kdasaparna; +Cc: gregkh, lidza.louina, devel, driverdev-devel, linux-kernel The patch is mangled. Read Documentation/email-clients.txt regards, dan carpenter ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/3] [PATCH] staging: lustre: llite: Fix No space after the declaration
@ 2015-07-24 12:46 Aparna Karuthodi
2015-07-24 14:00 ` [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks Aparna Karuthodi
0 siblings, 1 reply; 3+ messages in thread
From: Aparna Karuthodi @ 2015-07-24 12:46 UTC (permalink / raw)
To: linux-kernel; +Cc: Aparna Karuthodi
Added a new line
Signed-off-by:Aparna Karuthodi <kdasaparna@gmail.com>
---
drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
static inline int obd_capa_open_count(struct obd_capa *oc)
{
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(&lli->lli_open_count);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks 2015-07-24 12:46 [PATCH 1/3] [PATCH] staging: lustre: llite: Fix No space after the declaration Aparna Karuthodi @ 2015-07-24 14:00 ` Aparna Karuthodi 0 siblings, 0 replies; 3+ messages in thread From: Aparna Karuthodi @ 2015-07-24 14:00 UTC (permalink / raw) To: linux-kernel; +Cc: Aparna Karuthodi Removed the braces of if else statements which contain only one statement Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index f81a375..6cd0b6a 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) * 3) NONE - Do nothing. Since we didn't do anything to turn off the * other side, we don't need to do anything now. */ - if (qleft > (RQUEUESIZE / 2)) { + if (qleft > (RQUEUESIZE / 2)) /* HWFLOW */ if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) { if (ch->ch_flags & CH_RECEIVER_OFF) { @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch) ch->ch_bd->bd_ops->send_start_character(ch); } /* No FLOW */ - else { + else /* Nothing needed. */ - } - } + + } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-24 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-06 6:22 [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks kdasaparna
2015-06-06 8:47 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-07-24 12:46 [PATCH 1/3] [PATCH] staging: lustre: llite: Fix No space after the declaration Aparna Karuthodi
2015-07-24 14:00 ` [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks Aparna Karuthodi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.