All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes
Date: Sat, 6 Jun 2015 13:58:33 +0200	[thread overview]
Message-ID: <20150606115833.GP23777@lukather> (raw)
In-Reply-To: <fd4fcd83d901b2563ddbce84b339f42778c71260.1433494491.git.maitysanchayan@gmail.com>

Hi,

On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote:
> Add a device tree node for the On-Chip One Time Programmable
> Controller (OCOTP) and the On-Chip ROM.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 2f4b04d..ed9b6b8 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -56,6 +56,13 @@
>  		compatible = "simple-bus";
>  		interrupt-parent = <&mscm_ir>;
>  		ranges;
> +		ocotp-cfg = <&ocotp 0x410 0x420>;
> +		rom-revision = <&ocrom 0x80>;
> +
> +		ocrom: ocrom {
> +			compatible = "fsl,vf610-ocrom", "syscon";
> +			reg = <0x00000000 0x18000>;
> +		};

Shouldn't that use the new nvmem framework currently being discussed,
instead of defining custom bindings?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150606/502566bf/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: arnd-r2nGTMty4D4@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	stefan-XLVq0VzYD2Y@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes
Date: Sat, 6 Jun 2015 13:58:33 +0200	[thread overview]
Message-ID: <20150606115833.GP23777@lukather> (raw)
In-Reply-To: <fd4fcd83d901b2563ddbce84b339f42778c71260.1433494491.git.maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Hi,

On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote:
> Add a device tree node for the On-Chip One Time Programmable
> Controller (OCOTP) and the On-Chip ROM.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 2f4b04d..ed9b6b8 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -56,6 +56,13 @@
>  		compatible = "simple-bus";
>  		interrupt-parent = <&mscm_ir>;
>  		ranges;
> +		ocotp-cfg = <&ocotp 0x410 0x420>;
> +		rom-revision = <&ocrom 0x80>;
> +
> +		ocrom: ocrom {
> +			compatible = "fsl,vf610-ocrom", "syscon";
> +			reg = <0x00000000 0x18000>;
> +		};

Shouldn't that use the new nvmem framework currently being discussed,
instead of defining custom bindings?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: arnd@arndb.de, shawn.guo@linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	stefan@agner.ch, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes
Date: Sat, 6 Jun 2015 13:58:33 +0200	[thread overview]
Message-ID: <20150606115833.GP23777@lukather> (raw)
In-Reply-To: <fd4fcd83d901b2563ddbce84b339f42778c71260.1433494491.git.maitysanchayan@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Hi,

On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote:
> Add a device tree node for the On-Chip One Time Programmable
> Controller (OCOTP) and the On-Chip ROM.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 2f4b04d..ed9b6b8 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -56,6 +56,13 @@
>  		compatible = "simple-bus";
>  		interrupt-parent = <&mscm_ir>;
>  		ranges;
> +		ocotp-cfg = <&ocotp 0x410 0x420>;
> +		rom-revision = <&ocrom 0x80>;
> +
> +		ocrom: ocrom {
> +			compatible = "fsl,vf610-ocrom", "syscon";
> +			reg = <0x00000000 0x18000>;
> +		};

Shouldn't that use the new nvmem framework currently being discussed,
instead of defining custom bindings?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-06-06 11:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  9:22 [PATCH v5 0/2] Implement SoC bus support for Vybrid Sanchayan Maity
2015-06-05  9:22 ` Sanchayan Maity
2015-06-05  9:22 ` Sanchayan Maity
2015-06-05  9:22 ` [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Sanchayan Maity
2015-06-05  9:22   ` Sanchayan Maity
2015-06-05  9:22   ` Sanchayan Maity
2015-06-06 11:58   ` Maxime Ripard [this message]
2015-06-06 11:58     ` Maxime Ripard
2015-06-06 11:58     ` Maxime Ripard
2015-06-08  4:37     ` maitysanchayan at gmail.com
2015-06-08  4:37       ` maitysanchayan
2015-06-10 16:16       ` Maxime Ripard
2015-06-10 16:16         ` Maxime Ripard
2015-06-10 16:16         ` Maxime Ripard
2015-06-05  9:22 ` [PATCH v5 2/2] soc: Add driver for Freescale Vybrid Platform Sanchayan Maity
2015-06-05  9:22   ` Sanchayan Maity
2015-06-06 10:26   ` Paul Bolle
2015-06-06 10:26     ` Paul Bolle
2015-06-08  4:39     ` maitysanchayan at gmail.com
2015-06-08  4:39       ` maitysanchayan
2015-06-08  4:39       ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150606115833.GP23777@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.