From: Alexander Aring <alex.aring@gmail.com>
To: Stefan Schmidt <stefan@osg.samsung.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open()
Date: Tue, 9 Jun 2015 09:52:00 +0200 [thread overview]
Message-ID: <20150609075010.GA1402@omega> (raw)
In-Reply-To: <1433794000-10501-1-git-send-email-stefan@osg.samsung.com>
On Mon, Jun 08, 2015 at 10:06:40PM +0200, Stefan Schmidt wrote:
> This call was used before we aligned our code with the wireless code base. We
> are wanted to handle this in the err: code path. Which would actually not work
> because the WARN_ON() macro would reset the res value to 0 and thus we would
> never hit err:. Removing it makes the code do what we actually intend.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Please next time "subsytem: file:" or only "subsytem:" in the subject.
But not "subsytem/subsubsystem:". Thanks.
- Alex
prev parent reply other threads:[~2015-06-09 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 20:06 [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open() Stefan Schmidt
2015-06-09 7:44 ` Marcel Holtmann
2015-06-09 7:52 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609075010.GA1402@omega \
--to=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=stefan@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.