* [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open()
@ 2015-06-08 20:06 Stefan Schmidt
2015-06-09 7:44 ` Marcel Holtmann
2015-06-09 7:52 ` Alexander Aring
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Schmidt @ 2015-06-08 20:06 UTC (permalink / raw)
To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt
This call was used before we aligned our code with the wireless code base. We
are wanted to handle this in the err: code path. Which would actually not work
because the WARN_ON() macro would reset the res value to 0 and thus we would
never hit err:. Removing it makes the code do what we actually intend.
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
net/mac802154/iface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c
index 3a67d35..e3d77b0 100644
--- a/net/mac802154/iface.c
+++ b/net/mac802154/iface.c
@@ -147,7 +147,6 @@ static int mac802154_slave_open(struct net_device *dev)
if (!local->open_count) {
res = drv_start(local);
- WARN_ON(res);
if (res)
goto err;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open()
2015-06-08 20:06 [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open() Stefan Schmidt
@ 2015-06-09 7:44 ` Marcel Holtmann
2015-06-09 7:52 ` Alexander Aring
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-06-09 7:44 UTC (permalink / raw)
To: Stefan Schmidt; +Cc: linux-wpan, Alexander Aring
Hi Stefan,
> This call was used before we aligned our code with the wireless code base. We
> are wanted to handle this in the err: code path. Which would actually not work
> because the WARN_ON() macro would reset the res value to 0 and thus we would
> never hit err:. Removing it makes the code do what we actually intend.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
> net/mac802154/iface.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open()
2015-06-08 20:06 [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open() Stefan Schmidt
2015-06-09 7:44 ` Marcel Holtmann
@ 2015-06-09 7:52 ` Alexander Aring
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2015-06-09 7:52 UTC (permalink / raw)
To: Stefan Schmidt; +Cc: linux-wpan
On Mon, Jun 08, 2015 at 10:06:40PM +0200, Stefan Schmidt wrote:
> This call was used before we aligned our code with the wireless code base. We
> are wanted to handle this in the err: code path. Which would actually not work
> because the WARN_ON() macro would reset the res value to 0 and thus we would
> never hit err:. Removing it makes the code do what we actually intend.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Please next time "subsytem: file:" or only "subsytem:" in the subject.
But not "subsytem/subsubsystem:". Thanks.
- Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-09 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-08 20:06 [PATCH] mac802154/iface: remove superfluous WARN_ON call in slave_open() Stefan Schmidt
2015-06-09 7:44 ` Marcel Holtmann
2015-06-09 7:52 ` Alexander Aring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.