All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Ryusuke Konishi
	<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: Heinz Diehl <htd+ml-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: NILFS2: double uuid
Date: Tue, 9 Jun 2015 10:53:29 +0200	[thread overview]
Message-ID: <20150609085329.GF1992@ws.net.home> (raw)
In-Reply-To: <20150609.003127.1516615115859573912.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>

On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote:
> It looks like the backup super block should be dropped from candidates
> if its device size (sbp->s_dev_size) doesn't match the partition size.

Yeah, fixed:
http://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=00817742ce360119e079a33e12cf84118ff7c63e

Note that workaround is to not use nilfs2 on the last partition or
have a tiny gap (1 sector is enough) between last partition and the 
end of the whole-disk.

    Karel

-- 
 Karel Zak  <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Karel Zak <kzak@redhat.com>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Heinz Diehl <htd+ml@fritha.org>,
	linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: Re: NILFS2: double uuid
Date: Tue, 9 Jun 2015 10:53:29 +0200	[thread overview]
Message-ID: <20150609085329.GF1992@ws.net.home> (raw)
In-Reply-To: <20150609.003127.1516615115859573912.konishi.ryusuke@lab.ntt.co.jp>

On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote:
> It looks like the backup super block should be dropped from candidates
> if its device size (sbp->s_dev_size) doesn't match the partition size.

Yeah, fixed:
http://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=00817742ce360119e079a33e12cf84118ff7c63e

Note that workaround is to not use nilfs2 on the last partition or
have a tiny gap (1 sector is enough) between last partition and the 
end of the whole-disk.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  parent reply	other threads:[~2015-06-09  8:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08  6:43 NILFS2: double uuid Heinz Diehl
2015-06-08  6:47 ` Heinz Diehl
2015-06-08  8:18 ` Ryusuke Konishi
     [not found]   ` <55754FDA.10406-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08  9:45     ` Heinz Diehl
2015-06-08  9:45       ` Heinz Diehl
     [not found]       ` <20150608094559.GB15702-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-08 10:08         ` Heinz Diehl
2015-06-08 10:08           ` Heinz Diehl
     [not found]           ` <20150608100835.GA16569-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-08 10:12             ` Heinz Diehl
2015-06-08 10:12               ` Heinz Diehl
2015-06-08 10:31             ` Ryusuke Konishi
2015-06-08 10:31               ` Ryusuke Konishi
     [not found]               ` <55756F17.7080603-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08 15:31                 ` Ryusuke Konishi
2015-06-08 15:31                   ` Ryusuke Konishi
     [not found]                   ` <20150609.003127.1516615115859573912.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-08 17:23                     ` Heinz Diehl
2015-06-08 17:23                       ` Heinz Diehl
     [not found]                       ` <20150608172324.GA7760-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org>
2015-06-09  5:45                         ` Heinz Diehl
2015-06-09  5:45                           ` Heinz Diehl
2015-06-09  8:53                     ` Karel Zak [this message]
2015-06-09  8:53                       ` Karel Zak
2015-06-09  9:46                       ` Heinz Diehl
     [not found]                       ` <20150609085329.GF1992-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2015-06-09 13:04                         ` Ryusuke Konishi
2015-06-09 13:04                           ` Ryusuke Konishi
     [not found]                           ` <5576E44F.5030201-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2015-06-09 14:07                             ` Karel Zak
2015-06-09 14:07                               ` Karel Zak
     [not found]                               ` <20150609140742.GH1992-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2015-06-09 16:00                                 ` Ryusuke Konishi
2015-06-09 16:00                                   ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609085329.GF1992@ws.net.home \
    --to=kzak-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=htd+ml-iEI8Y0CNJBYdnm+yROfE0A@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.