All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Stefan Agner <stefan@agner.ch>
Cc: mark.rutland@arm.com, boris.brezillon@free-electrons.com,
	aaron@tastycactus.com, pawel.moll@arm.com, marb@ixxat.de,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	shawn.guo@linaro.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, linux-mtd@lists.infradead.org,
	kernel@pengutronix.de, galak@codeaurora.org,
	computersforpeace@gmail.com, dwmw2@infradead.org,
	linux-arm-kernel@lists.infradead.org, bpringlemeir@nbsps.com
Subject: Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 9 Jun 2015 22:07:51 +0200	[thread overview]
Message-ID: <20150609200751.GC5720@breakpoint.cc> (raw)
In-Reply-To: <b3b09b4b8c97cbfc88fa0d5fdc5e40cd@agner.ch>

On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote:
> As Boris guessed correctly, the reason I used the raw variant was due to
> performance improvements due to the barrier. However, I will use

yeah, do you have any numbers by chance?

> {read|write}l_relaxed instead, which should offer endian abstraction
> while not having the performance penalty due to extensive barriers...

well, even those
|$ git grep readl_relaxed arch/powerpc/
|arch/powerpc/include/asm/io.h:#define readl_relaxed(addr) readl(addr)

have the endian swap. So an abstraction like you provided earlier
would be nice :)

> --
> Stefan

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 9 Jun 2015 22:07:51 +0200	[thread overview]
Message-ID: <20150609200751.GC5720@breakpoint.cc> (raw)
In-Reply-To: <b3b09b4b8c97cbfc88fa0d5fdc5e40cd@agner.ch>

On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote:
> As Boris guessed correctly, the reason I used the raw variant was due to
> performance improvements due to the barrier. However, I will use

yeah, do you have any numbers by chance?

> {read|write}l_relaxed instead, which should offer endian abstraction
> while not having the performance penalty due to extensive barriers...

well, even those
|$ git grep readl_relaxed arch/powerpc/
|arch/powerpc/include/asm/io.h:#define readl_relaxed(addr) readl(addr)

have the endian swap. So an abstraction like you provided earlier
would be nice :)

> --
> Stefan

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	aaron-yuhzfaV+M/Wz3Dx2OeFgIA@public.gmane.org,
	marb-Z4QKGCRq86k@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	bpringlemeir-ygJ1pmMJ17cAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 9 Jun 2015 22:07:51 +0200	[thread overview]
Message-ID: <20150609200751.GC5720@breakpoint.cc> (raw)
In-Reply-To: <b3b09b4b8c97cbfc88fa0d5fdc5e40cd-XLVq0VzYD2Y@public.gmane.org>

On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote:
> As Boris guessed correctly, the reason I used the raw variant was due to
> performance improvements due to the barrier. However, I will use

yeah, do you have any numbers by chance?

> {read|write}l_relaxed instead, which should offer endian abstraction
> while not having the performance penalty due to extensive barriers...

well, even those
|$ git grep readl_relaxed arch/powerpc/
|arch/powerpc/include/asm/io.h:#define readl_relaxed(addr) readl(addr)

have the endian swap. So an abstraction like you provided earlier
would be nice :)

> --
> Stefan

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Stefan Agner <stefan@agner.ch>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	mark.rutland@arm.com, boris.brezillon@free-electrons.com,
	aaron@tastycactus.com, marb@ixxat.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	galak@codeaurora.org, shawn.guo@linaro.org,
	linux-arm-kernel@lists.infradead.org, bpringlemeir@nbsps.com
Subject: Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date: Tue, 9 Jun 2015 22:07:51 +0200	[thread overview]
Message-ID: <20150609200751.GC5720@breakpoint.cc> (raw)
In-Reply-To: <b3b09b4b8c97cbfc88fa0d5fdc5e40cd@agner.ch>

On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote:
> As Boris guessed correctly, the reason I used the raw variant was due to
> performance improvements due to the barrier. However, I will use

yeah, do you have any numbers by chance?

> {read|write}l_relaxed instead, which should offer endian abstraction
> while not having the performance penalty due to extensive barriers...

well, even those
|$ git grep readl_relaxed arch/powerpc/
|arch/powerpc/include/asm/io.h:#define readl_relaxed(addr) readl(addr)

have the endian swap. So an abstraction like you provided earlier
would be nice :)

> --
> Stefan

Sebastian

  reply	other threads:[~2015-06-09 20:07 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 16:28 [PATCH v4 0/6] mtd: nand: vf610_nfc: Freescale NFC for VF610 Stefan Agner
2015-03-25 16:28 ` Stefan Agner
2015-03-25 16:28 ` Stefan Agner
2015-03-25 16:28 ` [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-06-02  1:32   ` Brian Norris
2015-06-02  1:32     ` Brian Norris
2015-06-02  1:32     ` Brian Norris
2015-06-02  1:32     ` Brian Norris
2015-06-02  9:01     ` Stefan Agner
2015-06-02  9:01       ` Stefan Agner
2015-06-02  9:01       ` Stefan Agner
2015-06-03  8:10   ` Sebastian Andrzej Siewior
2015-06-03  8:10     ` Sebastian Andrzej Siewior
2015-06-03  8:10     ` Sebastian Andrzej Siewior
2015-06-03  9:45     ` Stefan Agner
2015-06-03  9:45       ` Stefan Agner
2015-06-03  9:45       ` Stefan Agner
2015-06-03 12:03       ` Sebastian Andrzej Siewior
2015-06-03 12:03         ` Sebastian Andrzej Siewior
2015-06-03 12:03         ` Sebastian Andrzej Siewior
2015-06-03 12:03         ` Sebastian Andrzej Siewior
2015-06-03 15:09         ` Stefan Agner
2015-06-03 15:09           ` Stefan Agner
2015-06-03 15:09           ` Stefan Agner
2015-06-03 15:09           ` Stefan Agner
2015-06-09 20:05           ` Sebastian Andrzej Siewior
2015-06-09 20:05             ` Sebastian Andrzej Siewior
2015-06-09 20:05             ` Sebastian Andrzej Siewior
2015-06-09 20:05             ` Sebastian Andrzej Siewior
2015-06-03 13:08   ` Sebastian Andrzej Siewior
2015-06-03 13:08     ` Sebastian Andrzej Siewior
2015-06-03 13:08     ` Sebastian Andrzej Siewior
2015-06-03 13:08     ` Sebastian Andrzej Siewior
2015-06-03 15:05     ` Stefan Agner
2015-06-03 15:05       ` Stefan Agner
2015-06-03 15:05       ` Stefan Agner
2015-06-03 15:05       ` Stefan Agner
2015-06-09 20:07       ` Sebastian Andrzej Siewior [this message]
2015-06-09 20:07         ` Sebastian Andrzej Siewior
2015-06-09 20:07         ` Sebastian Andrzej Siewior
2015-06-09 20:07         ` Sebastian Andrzej Siewior
2015-06-09 20:31         ` Stefan Agner
2015-06-09 20:31           ` Stefan Agner
2015-06-09 20:31           ` Stefan Agner
2015-06-09 20:31           ` Stefan Agner
2015-06-12 19:44           ` Sebastian Andrzej Siewior
2015-06-12 19:44             ` Sebastian Andrzej Siewior
2015-06-12 19:44             ` Sebastian Andrzej Siewior
2015-06-17 13:02         ` Stefan Agner
2015-06-17 13:02           ` Stefan Agner
2015-06-17 13:02           ` Stefan Agner
2015-06-18 18:27           ` Sebastian Andrzej Siewior
2015-06-18 18:27             ` Sebastian Andrzej Siewior
2015-06-18 18:27             ` Sebastian Andrzej Siewior
2015-06-18 18:27             ` Sebastian Andrzej Siewior
2015-03-25 16:28 ` [PATCH v4 2/6] mtd: nand: vf610_nfc: add hardware BCH-ECC support Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28 ` [PATCH v4 3/6] mtd: nand: vf610_nfc: add device tree bindings Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28 ` [PATCH v4 4/6] ARM: vf610: enable NAND Flash Controller Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28 ` [PATCH v4 5/6] ARM: dts: vf610: add NAND flash controller peripherial Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28 ` [PATCH v4 6/6] ARM: dts: vf-colibri: enable NAND flash controller Stefan Agner
2015-03-25 16:28   ` Stefan Agner
2015-03-25 16:28   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609200751.GC5720@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=aaron@tastycactus.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=bpringlemeir@nbsps.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marb@ixxat.de \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.