Re: [V4, 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]


> If ii is alright with you I will change the  dev_err(...)messages to
> dev_dbg(...) so that they do not spoil the logs.

OK.

> >> +     rc = of_property_read_string(dev->device->of_node, "interrupt-names",
> >> +                                  &int_name);
> >
> > I haven't checked but is that really needed? of_irq_to_resource() seems
> > to parse the "interrupt-names" property
> 
> Since the driver also fall's back to polling it will not work in case
> there is no irq domain assigned. The above approach works for both
> cases. So we do need it.

I still wonder if there isn't a better way since the name of the
resource is set already, but if so we can fix this incrementally, so OK
for now.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]