* re: lpfc: Fix rport leak.
@ 2015-06-10 15:48 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-06-10 15:48 UTC (permalink / raw)
To: james.smart; +Cc: linux-scsi
Hello James Smart,
This is a semi-automatic email about new static checker warnings.
The patch 466e840b7809: "lpfc: Fix rport leak." from May 21, 2015,
leads to the following Smatch complaint:
drivers/scsi/lpfc/lpfc_hbadisc.c:3905 lpfc_register_remote_port()
error: we previously assumed 'rdata' could be null (see line 3903)
drivers/scsi/lpfc/lpfc_hbadisc.c
3902 ndlp->rport = NULL;
3903 if (rdata && rdata->pnode == ndlp)
^^^^^
Patch introduces a new check.
3904 lpfc_nlp_put(ndlp);
3905 rdata->pnode = NULL;
^^^^^^^^^^^^
Unchecked dereference.
3906 /* drop reference for earlier registeration */
3907 put_device(&rport->dev);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-10 15:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 15:48 lpfc: Fix rport leak Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.