From: Dan Carpenter <dan.carpenter@oracle.com>
To: Firo Yang <firogm@gmail.com>
Cc: neilb@suse.de, linux-raid@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] md: fix a build warning
Date: Wed, 10 Jun 2015 16:07:22 +0000 [thread overview]
Message-ID: <20150610160722.GF28762@mwanda> (raw)
In-Reply-To: <1433949658-8455-1-git-send-email-firogm@gmail.com>
On Wed, Jun 10, 2015 at 11:20:58PM +0800, Firo Yang wrote:
> By the way, I also fixed a line over 80 characters warning outputed
> by ./scripts/checkpatch.pl
Don't do this. It's not on the same line, it's not really related at
all.
> mddev->chunk_sectors != info->chunk_size >> 9 ||
> - /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */
> + /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT
> + to change */
The new comment style isn't correct.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Firo Yang <firogm@gmail.com>
Cc: neilb@suse.de, linux-raid@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] md: fix a build warning
Date: Wed, 10 Jun 2015 19:07:22 +0300 [thread overview]
Message-ID: <20150610160722.GF28762@mwanda> (raw)
In-Reply-To: <1433949658-8455-1-git-send-email-firogm@gmail.com>
On Wed, Jun 10, 2015 at 11:20:58PM +0800, Firo Yang wrote:
> By the way, I also fixed a line over 80 characters warning outputed
> by ./scripts/checkpatch.pl
Don't do this. It's not on the same line, it's not really related at
all.
> mddev->chunk_sectors != info->chunk_size >> 9 ||
> - /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */
> + /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT
> + to change */
The new comment style isn't correct.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-10 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:20 [PATCH] md: fix a build warning Firo Yang
2015-06-10 15:20 ` Firo Yang
2015-06-10 16:07 ` Dan Carpenter [this message]
2015-06-10 16:07 ` Dan Carpenter
2015-06-10 17:32 ` walter harms
2015-06-10 17:32 ` walter harms
2015-06-10 17:36 ` Julia Lawall
2015-06-10 17:36 ` Julia Lawall
2015-06-10 18:04 ` walter harms
2015-06-10 18:04 ` walter harms
2015-06-10 20:38 ` Neil Brown
2015-06-10 20:38 ` Neil Brown
2015-06-10 20:34 ` Neil Brown
2015-06-10 20:34 ` Neil Brown
2015-06-11 11:48 ` Dan Carpenter
2015-06-11 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610160722.GF28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=firogm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.