From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode
Date: Wed, 10 Jun 2015 22:19:23 +0530 [thread overview]
Message-ID: <20150610164923.GV28601@localhost> (raw)
In-Reply-To: <20150608205351.GC23777@lukather>
On Mon, Jun 08, 2015 at 10:53:51PM +0200, Maxime Ripard wrote:
> Hi Vinod,
>
> On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote:
> > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote:
> > > From: Lior Amsalem <alior@marvell.com>
> > >
> > > The Marvell Armada 38x SoC introduce new features to the XOR engine,
> > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of
> > > the descriptor and not set through the controller registers.
> > >
> > > This new feature allows mixing of different commands (even PQ) on the same
> > > channel/chain without the need to stop the engine to reconfigure the engine
> > > mode.
> > >
> > > Refactor the driver to be able to use that new feature on the Armada 38x,
> > > while keeping the old behaviour on the older SoCs.
> > >
> > > Signed-off-by: Lior Amsalem <alior@marvell.com>
> > > Reviewed-by: Ofer Heifetz <oferh@marvell.com>
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > ---
> > > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +-
> > > drivers/dma/mv_xor.c | 82 ++++++++++++++++++++----
> > > drivers/dma/mv_xor.h | 7 ++
> > > 3 files changed, 76 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > index 7c6cb7fcecd2..cc29c35266e2 100644
> > > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > @@ -1,7 +1,7 @@
> > > * Marvell XOR engines
> > >
> > > Required properties:
> > > -- compatible: Should be "marvell,orion-xor"
> > > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor"
> >
> > marvell,armada-380-xor doesnt seem to exist in binding ?
>
> I'm not sure what you mean, this patch precisely adds that compatible
> to the bindings documentation.
Ah my bad, didnt payrequired attention, trusted checkpatch warn.
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas@free-electrons.com>
Subject: Re: [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode
Date: Wed, 10 Jun 2015 22:19:23 +0530 [thread overview]
Message-ID: <20150610164923.GV28601@localhost> (raw)
In-Reply-To: <20150608205351.GC23777@lukather>
On Mon, Jun 08, 2015 at 10:53:51PM +0200, Maxime Ripard wrote:
> Hi Vinod,
>
> On Mon, Jun 08, 2015 at 04:04:47PM +0530, Vinod Koul wrote:
> > On Tue, May 26, 2015 at 03:07:34PM +0200, Maxime Ripard wrote:
> > > From: Lior Amsalem <alior@marvell.com>
> > >
> > > The Marvell Armada 38x SoC introduce new features to the XOR engine,
> > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of
> > > the descriptor and not set through the controller registers.
> > >
> > > This new feature allows mixing of different commands (even PQ) on the same
> > > channel/chain without the need to stop the engine to reconfigure the engine
> > > mode.
> > >
> > > Refactor the driver to be able to use that new feature on the Armada 38x,
> > > while keeping the old behaviour on the older SoCs.
> > >
> > > Signed-off-by: Lior Amsalem <alior@marvell.com>
> > > Reviewed-by: Ofer Heifetz <oferh@marvell.com>
> > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > ---
> > > Documentation/devicetree/bindings/dma/mv-xor.txt | 2 +-
> > > drivers/dma/mv_xor.c | 82 ++++++++++++++++++++----
> > > drivers/dma/mv_xor.h | 7 ++
> > > 3 files changed, 76 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/dma/mv-xor.txt b/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > index 7c6cb7fcecd2..cc29c35266e2 100644
> > > --- a/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > +++ b/Documentation/devicetree/bindings/dma/mv-xor.txt
> > > @@ -1,7 +1,7 @@
> > > * Marvell XOR engines
> > >
> > > Required properties:
> > > -- compatible: Should be "marvell,orion-xor"
> > > +- compatible: Should be "marvell,orion-xor" or "marvell,armada-380-xor"
> >
> > marvell,armada-380-xor doesnt seem to exist in binding ?
>
> I'm not sure what you mean, this patch precisely adds that compatible
> to the bindings documentation.
Ah my bad, didnt payrequired attention, trusted checkpatch warn.
--
~Vinod
next prev parent reply other threads:[~2015-06-10 16:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:07 [PATCH v2 0/5] dmaengine: mv_xor: Fixes and enhancements Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-05-26 13:07 ` [PATCH v2 1/5] dmaengine: mv_xor: bug fix for racing condition in descriptors cleanup Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-05-26 13:07 ` [PATCH v2 2/5] dmaengine: mv_xor: Rename function for consistent naming Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-05-26 13:07 ` [PATCH v2 3/5] dmaengine: mv_xor: add support for a38x command in descriptor mode Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-06-08 10:34 ` Vinod Koul
2015-06-08 10:34 ` Vinod Koul
2015-06-08 20:53 ` Maxime Ripard
2015-06-08 20:53 ` Maxime Ripard
2015-06-10 16:49 ` Vinod Koul [this message]
2015-06-10 16:49 ` Vinod Koul
2015-05-26 13:07 ` [PATCH v2 4/5] dmaengine: mv_xor: Enlarge descriptor pool size Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-05-26 13:07 ` [PATCH v2 5/5] dmaengine: mv_xor: improve descriptors list handling and reduce locking Maxime Ripard
2015-05-26 13:07 ` Maxime Ripard
2015-06-10 16:54 ` [PATCH v2 0/5] dmaengine: mv_xor: Fixes and enhancements Vinod Koul
2015-06-10 16:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610164923.GV28601@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.