From: Matthew Wilcox <willy@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org,
neilb@suse.de, gregkh@linuxfoundation.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-api@vger.kernel.org,
akpm@linux-foundation.org, mingo@kernel.org
Subject: Re: [PATCH v5 17/21] libnvdimm: infrastructure for btt devices
Date: Wed, 10 Jun 2015 14:46:16 -0400 [thread overview]
Message-ID: <20150610184616.GL2729@linux.intel.com> (raw)
In-Reply-To: <20150609064200.GE9804@lst.de>
On Tue, Jun 09, 2015 at 08:42:00AM +0200, Christoph Hellwig wrote:
> > The BTT driver is the initial first consumer of this mechanism to allow
> > layering atomic sector update guarantees on top of nd_io capable
> > libnvdimm-block-devices, or their partitions.
>
> As mentioned during the last time of the review the layering here
> is complete broken. If you expose additional capabilities from a block
> device do it at the block device level. That is enhance the rw_page
> callback to allo byte sized access, add a capability flag on the queue,
> etc.
Don't screw up rw_page. The point of rw_page is to read or write a page
cache page. It can sleep, and it indicates success by using the page
flags. Don't try and scqueeze rw_bytes into it. If you want rw_bytes
to be a queue operation, that's one thing, but don't mess with rw_page.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org,
neilb@suse.de, gregkh@linuxfoundation.org,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-api@vger.kernel.org,
akpm@linux-foundation.org, mingo@kernel.org
Subject: Re: [PATCH v5 17/21] libnvdimm: infrastructure for btt devices
Date: Wed, 10 Jun 2015 14:46:16 -0400 [thread overview]
Message-ID: <20150610184616.GL2729@linux.intel.com> (raw)
In-Reply-To: <20150609064200.GE9804@lst.de>
On Tue, Jun 09, 2015 at 08:42:00AM +0200, Christoph Hellwig wrote:
> > The BTT driver is the initial first consumer of this mechanism to allow
> > layering atomic sector update guarantees on top of nd_io capable
> > libnvdimm-block-devices, or their partitions.
>
> As mentioned during the last time of the review the layering here
> is complete broken. If you expose additional capabilities from a block
> device do it at the block device level. That is enhance the rw_page
> callback to allo byte sized access, add a capability flag on the queue,
> etc.
Don't screw up rw_page. The point of rw_page is to read or write a page
cache page. It can sleep, and it indicates success by using the page
flags. Don't try and scqueeze rw_bytes into it. If you want rw_bytes
to be a queue operation, that's one thing, but don't mess with rw_page.
next prev parent reply other threads:[~2015-06-10 18:46 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 0:14 [PATCH v5 00/21] libnvdimm: non-volatile memory devices Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 01/21] e820, efi: add ACPI 6.0 persistent memory types Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-03 14:57 ` Christoph Hellwig
2015-06-03 14:57 ` Christoph Hellwig
[not found] ` <20150603145704.GA22311-jcswGhMUV9g@public.gmane.org>
2015-06-03 19:24 ` Williams, Dan J
2015-06-03 19:24 ` Williams, Dan J
2015-06-03 19:24 ` Williams, Dan J
[not found] ` <1433359473.21035.27.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:33 ` hch-jcswGhMUV9g
2015-06-09 6:33 ` hch
2015-06-09 6:33 ` hch
2015-06-09 22:27 ` Dan Williams
2015-06-09 22:27 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 03/21] libnvdimm: control character device and libnvdimm bus sysfs attributes Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 04/21] libnvdimm, nfit: dimm/memory-devices Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 05/21] libnvdimm: control (ioctl) messages for libnvdimm bus and dimm devices Dan Williams
2015-06-02 0:14 ` Dan Williams
[not found] ` <20150602001435.4506.42614.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:34 ` Christoph Hellwig
2015-06-09 6:34 ` Christoph Hellwig
2015-06-09 6:34 ` Christoph Hellwig
[not found] ` <20150609063418.GB9804-jcswGhMUV9g@public.gmane.org>
2015-06-09 6:57 ` Dan Williams
2015-06-09 6:57 ` Dan Williams
2015-06-09 6:57 ` Dan Williams
[not found] ` <CAPcyv4jmHpg4YrseBWH-k=achv4N-V8n2X0CkFw+-AFsiRuH8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-10 7:33 ` Christoph Hellwig
2015-06-10 7:33 ` Christoph Hellwig
2015-06-10 7:33 ` Christoph Hellwig
2015-06-02 0:14 ` [PATCH v5 07/21] libnvdimm, nfit: regions (block-data-window, persistent memory, volatile memory) Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 08/21] libnvdimm: support for legacy (non-aliasing) nvdimms Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` [PATCH v5 09/21] libnvdimm, nd_pmem: add libnvdimm support to the pmem driver Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-03 7:44 ` Christoph Hellwig
[not found] ` <20150603074424.GA24949-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-06-03 19:31 ` Williams, Dan J
2015-06-03 19:31 ` Williams, Dan J
[not found] ` <1433359894.21035.33.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:36 ` hch-jcswGhMUV9g
2015-06-09 6:36 ` hch
2015-06-02 0:15 ` [PATCH v5 10/21] pmem: Dynamically allocate partition numbers Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 11/21] libnvdimm, nfit: add interleave-set state-tracking infrastructure Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 12/21] libnvdimm: namespace indices: read and validate Dan Williams
2015-06-02 0:15 ` Dan Williams
[not found] ` <20150602001514.4506.13974.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:39 ` Christoph Hellwig
2015-06-09 6:39 ` Christoph Hellwig
2015-06-09 6:39 ` Christoph Hellwig
2015-06-10 15:54 ` Dan Williams
2015-06-10 15:54 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 14/21] libnvdimm: blk labels and namespace instantiation Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 17/21] libnvdimm: infrastructure for btt devices Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-09 6:42 ` Christoph Hellwig
2015-06-09 6:42 ` Christoph Hellwig
2015-06-10 18:46 ` Matthew Wilcox [this message]
2015-06-10 18:46 ` Matthew Wilcox
2015-06-11 7:28 ` Christoph Hellwig
2015-06-11 7:28 ` Christoph Hellwig
[not found] ` <20150611072812.GB1905-jcswGhMUV9g@public.gmane.org>
2015-06-17 16:47 ` Jeff Moyer
2015-06-17 16:47 ` Jeff Moyer
[not found] ` <x49381qp9ic.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2015-06-17 16:50 ` Dan Williams
2015-06-17 16:50 ` Dan Williams
2015-06-17 16:57 ` Jeff Moyer
2015-06-17 16:57 ` Jeff Moyer
2015-06-17 17:09 ` Dan Williams
[not found] ` <20150602001134.4506.45867.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-02 0:14 ` [PATCH v5 06/21] libnvdimm, nvdimm: dimm driver and base libnvdimm device-driver infrastructure Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:14 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 13/21] libnvdimm: pmem label sets and namespace instantiation Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 15/21] libnvdimm: write pmem label set Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 16/21] libnvdimm: write blk " Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 18/21] nd_btt: atomic sector updates Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
[not found] ` <20150602001546.4506.15713.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:44 ` Christoph Hellwig
2015-06-09 6:44 ` Christoph Hellwig
2015-06-09 6:44 ` Christoph Hellwig
2015-06-09 18:27 ` Vishal Verma
2015-06-09 18:27 ` Vishal Verma
[not found] ` <1433874431.32607.37.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-06-10 7:34 ` Christoph Hellwig
2015-06-10 7:34 ` Christoph Hellwig
2015-06-10 7:34 ` Christoph Hellwig
2015-06-10 18:24 ` Vishal Verma
2015-06-10 18:24 ` Vishal Verma
2015-06-02 0:15 ` [PATCH v5 19/21] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` [PATCH v5 20/21] tools/testing/nvdimm: manufactured NFITs for interface development Dan Williams
2015-06-02 0:15 ` Dan Williams
2015-06-02 0:15 ` Dan Williams
[not found] ` <20150602001557.4506.57136.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-09 6:48 ` Christoph Hellwig
2015-06-09 6:48 ` Christoph Hellwig
2015-06-09 6:48 ` Christoph Hellwig
2015-06-11 20:12 ` Dan Williams
2015-06-11 20:12 ` Dan Williams
2015-06-02 0:16 ` [PATCH v5 21/21] libnvdimm: Non-Volatile Devices Dan Williams
2015-06-02 0:16 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610184616.GL2729@linux.intel.com \
--to=willy@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=rafael@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.