* Build error in -next due to 'MIPS: ath79: Improve the DDR controller interface'
@ 2015-06-05 14:41 Guenter Roeck
2015-06-07 9:41 ` [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base Alban Bedel
2015-06-10 21:01 ` Alban Bedel
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2015-06-05 14:41 UTC (permalink / raw)
To: linux-mips; +Cc: Ralf Baechle, Alban Bedel, linux-kernel@vger.kernel.org
In next-20150604:
Building mips:ath79_defconfig ... failed
--------------
Error log:
arch/mips/pci/pci-ar71xx.c: In function 'ar71xx_pci_reset':
arch/mips/pci/pci-ar71xx.c:321:27: error: 'ath79_ddr_base' undeclared (first use in this function)
arch/mips/pci/pci-ar71xx.c:321:27: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/pci/pci-ar71xx.c:321:16: warning: unused variable 'ddr_base' [-Wunused-variable]
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
2015-06-05 14:41 Build error in -next due to 'MIPS: ath79: Improve the DDR controller interface' Guenter Roeck
@ 2015-06-07 9:41 ` Alban Bedel
2015-06-10 21:01 ` Alban Bedel
1 sibling, 0 replies; 5+ messages in thread
From: Alban Bedel @ 2015-06-07 9:41 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Guenter Roeck, linux-mips, linux-kernel, Alban Bedel
The patch 'MIPS: ath79: Improve the DDR controller interface'
broke the PCI support as it failed to properly removed the use of the
variable 'ath79_ddr_base'. Remove that last reference to fix the build.
Signed-off-by: Alban Bedel <albeu@free.fr>
---
arch/mips/pci/pci-ar71xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/pci/pci-ar71xx.c b/arch/mips/pci/pci-ar71xx.c
index 72764d8..1391c52 100644
--- a/arch/mips/pci/pci-ar71xx.c
+++ b/arch/mips/pci/pci-ar71xx.c
@@ -318,8 +318,6 @@ static void ar71xx_pci_irq_init(struct ar71xx_pci_controller *apc)
static void ar71xx_pci_reset(void)
{
- void __iomem *ddr_base = ath79_ddr_base;
-
ath79_device_reset_set(AR71XX_RESET_PCI_BUS | AR71XX_RESET_PCI_CORE);
mdelay(100);
--
2.0.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
@ 2015-06-10 21:01 ` Alban Bedel
0 siblings, 0 replies; 5+ messages in thread
From: Alban Bedel @ 2015-06-10 21:01 UTC (permalink / raw)
To: linux-mips; +Cc: Alban Bedel
The patch 'MIPS: ath79: Improve the DDR controller interface'
broke the PCI support as it failed to properly removed the use of the
variable 'ath79_ddr_base'. Remove that last reference to fix the build.
Signed-off-by: Alban Bedel <albeu@free.fr>
---
arch/mips/pci/pci-ar71xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/pci/pci-ar71xx.c b/arch/mips/pci/pci-ar71xx.c
index 72764d8..1391c52 100644
--- a/arch/mips/pci/pci-ar71xx.c
+++ b/arch/mips/pci/pci-ar71xx.c
@@ -318,8 +318,6 @@ static void ar71xx_pci_irq_init(struct ar71xx_pci_controller *apc)
static void ar71xx_pci_reset(void)
{
- void __iomem *ddr_base = ath79_ddr_base;
-
ath79_device_reset_set(AR71XX_RESET_PCI_BUS | AR71XX_RESET_PCI_CORE);
mdelay(100);
--
2.0.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
@ 2015-06-10 21:01 ` Alban Bedel
0 siblings, 0 replies; 5+ messages in thread
From: Alban Bedel @ 2015-06-10 21:01 UTC (permalink / raw)
To: linux-mips; +Cc: Alban Bedel
The patch 'MIPS: ath79: Improve the DDR controller interface'
broke the PCI support as it failed to properly removed the use of the
variable 'ath79_ddr_base'. Remove that last reference to fix the build.
Signed-off-by: Alban Bedel <albeu@free.fr>
---
arch/mips/pci/pci-ar71xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/pci/pci-ar71xx.c b/arch/mips/pci/pci-ar71xx.c
index 72764d8..1391c52 100644
--- a/arch/mips/pci/pci-ar71xx.c
+++ b/arch/mips/pci/pci-ar71xx.c
@@ -318,8 +318,6 @@ static void ar71xx_pci_irq_init(struct ar71xx_pci_controller *apc)
static void ar71xx_pci_reset(void)
{
- void __iomem *ddr_base = ath79_ddr_base;
-
ath79_device_reset_set(AR71XX_RESET_PCI_BUS | AR71XX_RESET_PCI_CORE);
mdelay(100);
--
2.0.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
2015-06-10 21:01 ` Alban Bedel
(?)
@ 2015-06-10 22:00 ` Ralf Baechle
-1 siblings, 0 replies; 5+ messages in thread
From: Ralf Baechle @ 2015-06-10 22:00 UTC (permalink / raw)
To: Alban Bedel; +Cc: linux-mips
On Wed, Jun 10, 2015 at 11:01:12PM +0200, Alban Bedel wrote:
> The patch 'MIPS: ath79: Improve the DDR controller interface'
> broke the PCI support as it failed to properly removed the use of the
> variable 'ath79_ddr_base'. Remove that last reference to fix the build.
Thanks, I folded this into the original patch.
Ralf
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-10 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 14:41 Build error in -next due to 'MIPS: ath79: Improve the DDR controller interface' Guenter Roeck
2015-06-07 9:41 ` [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base Alban Bedel
2015-06-10 21:01 ` Alban Bedel
2015-06-10 21:01 ` Alban Bedel
2015-06-10 22:00 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.