Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Am 10.06.2015 um 22:55 hat John Snow geschrieben:
> On 06/10/2015 04:52 PM, Eric Blake wrote:
> > On 06/10/2015 11:24 AM, John Snow wrote:
> >> Requires: 1433796555-5608-1-git-send-email-jsnow@redhat.com 
> >> [PATCH] block: record new size in bdrv_dirty_bitmap_truncate
> >> 
> > 
> > Shouldn't this be after the '---' separator?
> > 
> 
> Sorry, not used to sending single patches without a cover letter.
> 
> Kevin: If it's not inconvenient for you to do, please delete these
> lines on commit.

No problem.

> >> This is an artifact of an older version that had both all-bitmap
> >> and single-bitmap truncate functions, and some info got lost in
> >> the shuffle.
> >> 
> >> Bitmaps can only be frozen during a backup operation, and a
> >> backup operation should prevent a resize operation, so just
> >> assert that this cannot happen.
> >> 
> >> Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: John
> >> Snow <jsnow@redhat.com> --- block.c | 4 +--- 1 file changed, 1
> >> insertion(+), 3 deletions(-)
> > 
> > Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks, applied to the block branch.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]